-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[preview] fix transparent preview widget background #6196
Conversation
Can still see Homer in the preferences settings and the Getting started page. |
I'll fix them as well, I believe widgets should have default backgrounds and not be transparent. |
4e269b8
to
c8f4d3a
Compare
@lmcbout the code has been updated to give a background-color to widgets present in the main content area. You can further test by dnd a widget from the sidebar into the main area |
Fixes #6194 - fixes an issue where widgets present in the main area had transparent backgrounds which interfered with custom branding. - adjusts the styling of the dockpanel to be more consistent with VSCode Signed-off-by: Vincent Fugnitto <[email protected]>
c8f4d3a
to
b3444e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Homer is Gone :(
Tested with DND, Getting started, preferences: OK
Tested on Firefox and Chrome
It looks like this bug is back :( |
@vince-fugnitto yes, it is a bug, we don't have such colors, please send another PR to apply suitable VS Code colors (not by value, but by meaning) |
This issue is still there Steps to reproduce:
Issue reference: #8444 |
What it does
Fixes #6194
master
)pr
)How to test
I made the following changes locally in the
index.css
so I can visualize the changes:README.md
or any markdown fileReview checklist
Reminder for reviewers
Signed-off-by: Vincent Fugnitto [email protected]