Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[preview] fix transparent preview widget background #6196

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Sep 16, 2019

What it does

Fixes #6194

  • Fixes an issue where widgets present in the main area had transparent backgrounds which interfered with custom branding. With the change, widgets now have default background colors.
  • Adjusts the styling of the dockpanel to be more consistent with VSCode
Before (master) After (pr)
image image

How to test

I made the following changes locally in the index.css so I can visualize the changes:

#theia-main-content-panel {
  background-image: url('https://assets.webiconspng.com/uploads/2017/09/Simpsons-PNG-Image-19701.png');
  background-position: center center;
  background-repeat: no-repeat;
  background-size: 50%;
}
  1. with the local changes, open a workspace (ex: 'theia')
  2. open a README.md or any markdown file
  3. click on preview in the markdown's tabbar toolbar
  4. confirm that the contributed image is not visible
  5. open any widget in the main area (ex: explorer, scm, getting-started, search) and ensure that styling is correct and the background image does not display

Review checklist

Reminder for reviewers

Signed-off-by: Vincent Fugnitto [email protected]

@vince-fugnitto vince-fugnitto added bug bugs found in the application preview issues related to the preview labels Sep 16, 2019
@vince-fugnitto vince-fugnitto self-assigned this Sep 16, 2019
@lmcbout
Copy link
Contributor

lmcbout commented Sep 17, 2019

Can still see Homer in the preferences settings and the Getting started page.

@vince-fugnitto
Copy link
Member Author

Can still see Homer in the preferences settings and the Getting started page.

I'll fix them as well, I believe widgets should have default backgrounds and not be transparent.

@vince-fugnitto
Copy link
Member Author

@lmcbout the code has been updated to give a background-color to widgets present in the main content area. You can further test by dnd a widget from the sidebar into the main area
(ex: explorer, scm, ...)

Fixes #6194

- fixes an issue where widgets present in the main area had transparent
backgrounds which interfered with custom branding.
- adjusts the styling of the dockpanel to be more consistent with VSCode

Signed-off-by: Vincent Fugnitto <[email protected]>
Copy link
Contributor

@lmcbout lmcbout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Homer is Gone :(
Tested with DND, Getting started, preferences: OK
Tested on Firefox and Chrome

@vince-fugnitto vince-fugnitto merged commit 24f77b3 into master Sep 19, 2019
@vince-fugnitto vince-fugnitto deleted the vf/GH-6194 branch September 19, 2019 12:34
@vince-fugnitto
Copy link
Member Author

It looks like this bug is back :(
@akosyakov is it a bug or what is by design to remove the behavior with the theming pull-request?

@akosyakov
Copy link
Member

@vince-fugnitto yes, it is a bug, we don't have such colors, please send another PR to apply suitable VS Code colors (not by value, but by meaning)

@GNSubrahmanyam
Copy link

GNSubrahmanyam commented Aug 30, 2020

@vince-fugnitto
image

This issue is still there

Steps to reproduce:

  1. go the preferences

Issue reference: #8444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application preview issues related to the preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview widget background is transparent causing isues with branding logo
4 participants