-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview widget background is transparent causing isues with branding logo #6194
Comments
AlexTugarev
added
bug
bugs found in the application
preview
issues related to the preview
labels
Sep 16, 2019
vince-fugnitto
added a commit
that referenced
this issue
Sep 16, 2019
Fixes #6194 - fixes an issue where the preview widget has a transparent background which causes problems whenever the background has content - adjusts the styling of the dockpanel to be more consistent with VSCode Signed-off-by: Vincent Fugnitto <[email protected]>
1 task
vince-fugnitto
added a commit
that referenced
this issue
Sep 17, 2019
Fixes #6194 - fixes an issue where the preview widget has a transparent background which causes problems whenever the background has content - adjusts the styling of the dockpanel to be more consistent with VSCode Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
added a commit
that referenced
this issue
Sep 17, 2019
Fixes #6194 - fixes an issue where widgets present in the main area had transparent backgrounds which interfered with custom branding. - adjusts the styling of the dockpanel to be more consistent with VSCode Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
added a commit
that referenced
this issue
Sep 19, 2019
Fixes #6194 - fixes an issue where widgets present in the main area had transparent backgrounds which interfered with custom branding. - adjusts the styling of the dockpanel to be more consistent with VSCode Signed-off-by: Vincent Fugnitto <[email protected]>
akosyakov
pushed a commit
to akosyakov/theia
that referenced
this issue
Feb 24, 2020
Fixes eclipse-theia#6194 - fixes an issue where widgets present in the main area had transparent backgrounds which interfered with custom branding. - adjusts the styling of the dockpanel to be more consistent with VSCode Signed-off-by: Vincent Fugnitto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
I added a branding extension similar to https://github.com/vince-fugnitto/theia-cpp-branding.
It works fine to the extent the logo is added to the empty panel.
But when I open the preview of a markdown file, the rendered output panel has a transparent background causing the logo to be visible and conflict with the rendered preview.
Reproduction Steps
OS and Theia version:
Theia Version:
next
cc: @vince-fugnitto
The text was updated successfully, but these errors were encountered: