Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files.associations property #4713

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Add files.associations property #4713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/filesystem/src/browser/filesystem-preferences.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,13 @@ export const filesystemPreferenceSchema: PreferenceSchema = {
'default': { '**/.git': true, '**/.svn': true, '**/.hg': true, '**/CVS': true, '**/.DS_Store': true },
'description': 'Configure glob patterns for excluding files and folders.',
'scope': 'resource'
}
},
'files.associations': {
Copy link
Member

@akosyakov akosyakov Mar 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tolusha Should not it be used somewhere? I.e. and editor language should be changed according it? not sure why it was merged and an issue was closed

incomplete feature should not land on master, there are products relying on next, they should not get a new preference which is not used

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's used by inteliphense feature there https://github.com/bmewburn/vscode-intelephense/search?q=files.associations&unscoped_q=files.associations

AFAIK you said it's important that master contains fixes for ppl that are blocked
#4521 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was finished thing, this code adds user feature which accessible but does not work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it allows several VS Code extensions to work. https://github.com/search?q=getConfiguration%28%27files%27%29.get%28%27associations%27%29%3B&type=Code

Please, what are you calling "finished thing" ? something that is making Theia accepting all VS Code extensions in a single commit ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it allows several VS Code extensions to work. https://github.com/search?q=getConfiguration%28%27files%27%29.get%28%27associations%27%29%3B&type=Code

i wonder how, even if extensions contribute it, it does not take any effect, it does not work

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well it allows the extension to be deployed ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not it be then just to be mocked in plugin-ext for now, without introducing user visible preferences?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, what are you calling "finished thing" ? something that is making Theia accepting all VS Code extensions in a single commit ?

For sure not, but one always has to consider how it affects existing users who don't even use VS Code extensions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tolusha could it be introduced only in plugin-ext ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will introduce a new PR.

'description': 'Configure file associations to languages (e.g. "*.extension": "html"). \
These have precedence over the default associations of the languages installed',
'type': 'object',
'default': {}
},
}
};

Expand Down