Add files.associations property #4713
Conversation
Signed-off-by: Anatoliy Bazko <[email protected]>
| @@ -43,7 +43,13 @@ export const filesystemPreferenceSchema: PreferenceSchema = { | |||
| 'default': { '**/.git': true, '**/.svn': true, '**/.hg': true, '**/CVS': true, '**/.DS_Store': true }, | |||
| 'description': 'Configure glob patterns for excluding files and folders.', | |||
| 'scope': 'resource' | |||
| } | |||
| }, | |||
| 'files.associations': { | |||
There was a problem hiding this comment.
@tolusha Should not it be used somewhere? I.e. and editor language should be changed according it? not sure why it was merged and an issue was closed
incomplete feature should not land on master, there are products relying on next, they should not get a new preference which is not used
There was a problem hiding this comment.
it's used by inteliphense feature there https://github.com/bmewburn/vscode-intelephense/search?q=files.associations&unscoped_q=files.associations
AFAIK you said it's important that master contains fixes for ppl that are blocked
#4521 (comment)
There was a problem hiding this comment.
It was finished thing, this code adds user feature which accessible but does not work.
There was a problem hiding this comment.
it allows several VS Code extensions to work. https://github.com/search?q=getConfiguration%28%27files%27%29.get%28%27associations%27%29%3B&type=Code
Please, what are you calling "finished thing" ? something that is making Theia accepting all VS Code extensions in a single commit ?
There was a problem hiding this comment.
it allows several VS Code extensions to work. https://github.com/search?q=getConfiguration%28%27files%27%29.get%28%27associations%27%29%3B&type=Code
i wonder how, even if extensions contribute it, it does not take any effect, it does not work
There was a problem hiding this comment.
well it allows the extension to be deployed ?
There was a problem hiding this comment.
Could not it be then just to be mocked in plugin-ext for now, without introducing user visible preferences?
There was a problem hiding this comment.
Please, what are you calling "finished thing" ? something that is making Theia accepting all VS Code extensions in a single commit ?
For sure not, but one always has to consider how it affects existing users who don't even use VS Code extensions.
There was a problem hiding this comment.
@tolusha could it be introduced only in plugin-ext ?
There was a problem hiding this comment.
ok, I will introduce a new PR.
Signed-off-by: Anatoliy Bazko [email protected]
Reference issue
#4581
What does this PR do
Adds
files.associationsproperty [1][1] https://code.visualstudio.com/docs/getstarted/settings