Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new built-in handler to open files with system application #13601

Merged

Conversation

dhuebner
Copy link
Member

What it does

Adds a new Command and an OpenWithService handler to open files using system application.

Bildschirmfoto 2024-04-12 um 15 06 50

How to test

  • Select a file in navigator. Call "Open With System Editor" command from the command palette.
  • ...or, from the Navigator menu. Select "Open With...". Select the new "System Editor" entry and press ENTER.

In both cases the file should be opened with your system default editor.

Follow-ups

This new command can be called to handle vscode.env.openExternal request, see #13535 .

Review checklist

Reminder for reviewers

@dhuebner dhuebner changed the title Add a new built-in handler to open files with system application #13535 Add a new built-in handler to open files with system application Apr 12, 2024
@dhuebner dhuebner force-pushed the dhuebner/openWithSystemEditor-13535 branch from 0b365bd to bd1bf8e Compare April 19, 2024 08:27
@tsmaeder tsmaeder merged commit 7969734 into eclipse-theia:master Apr 22, 2024
12 of 14 checks passed
@jfaltermeier jfaltermeier added this to the 1.49.0 milestone Apr 29, 2024
@dhuebner dhuebner deleted the dhuebner/openWithSystemEditor-13535 branch October 11, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants