Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Uri#path#fsPath in FileUri.fsPath() #13620

Open
dhuebner opened this issue Apr 19, 2024 · 0 comments
Open

Use Uri#path#fsPath in FileUri.fsPath() #13620

dhuebner opened this issue Apr 19, 2024 · 0 comments

Comments

@dhuebner
Copy link
Member

Uri#path#fsPath() deals better with the case where backend and frontend are running on different OS.

See discussion here.

FileUri.fsPath() used to be exclusively used on the backend (I believe you moved it from node to common recently), where the only available OS was the backend OS. With that in mind, it was never an issue previously. Changing it to forward to Uri#path#fsPath would probably be a good idea though.

Originally posted by @msujew in #13601 (comment)

Feature Description:

FileUri.fsPath() should internally use Uri#path#fsPath() for conversion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant