workspace: fix untitled file-saving #12577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
core
There was a problem hiding this comment.
I gave the review offline but for transparency I'll include an update.
We should align the behavior when closing the application and there are unsaved changes with VS Code by:
- prompting once for all unsaved changes (resources + untitled resources)
- selecting
save allfrom the dialog should save all resources, and should prompt to select a location for the untitled resources (similarly tosave as...) - we should attempt to save the untitled resources in the current workspace by default (might be tricky since we do not know about workspaces in
@theia/core)
This should fix the main user-experience issues present in the pull-request where we prompt for each untitled file whether we want to save or not. It also fixes the issue where if we dont save the untitled files we still show them later in the main "save all" dialog.
|
@vladarama Is this ready for a re-review? |
vladarama
force-pushed
the
gh-12557-workspace-save-fixes
branch
from
4a95793
to
1ca2420
Compare
This commit fixes the untitled file-saving issue by making sure that the untitled files are saved correctly before closing the workspace / closing the application. Signed-off-by: Vlad Arama <[email protected]>
vladarama
force-pushed
the
gh-12557-workspace-save-fixes
branch
from
1ca2420
to
14fea31
Compare
|
@JonasHelming |
This commit includes a refactoring of the `onWillStop()` method to prevent the workspace from closing when we decide to cancel the file saving dialog. Signed-off-by: Vlad Arama <[email protected]>
vince-fugnitto
approved these changes
Aug 23, 2023
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR fixes #12557 by fixing the untitled file saving behavior when closing the
Workspace. The user should now be prompted to select a location to save the untitled file before closing theWorkspace. The file should be saved at the chosen location, and theWorkspaceshould reload successfully, preserving the newly created file.How to test
File->AutoSaveFile->New FileorAlt+NFile->Close WorkspaceSaveand choose a location to save the fileWorkspaceand the newly created file should be saved successfullyReview checklist
Reminder for reviewers