Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Closing workspace does not save a new file #12557

Closed
vladarama opened this issue May 24, 2023 · 0 comments · Fixed by #12577
Closed

Bug: Closing workspace does not save a new file #12557

vladarama opened this issue May 24, 2023 · 0 comments · Fixed by #12577
Labels
bug bugs found in the application workspace issues related to the workspace

Comments

@vladarama
Copy link
Contributor

Bug Description:

With AutoSave turned off, closing the Workspace does not save a new file even after being prompted to save it.

Expected Behavior:

The user should be prompted to select a location to save the file before closing the Workspace. The file should be saved at the chosen location, and the workspace should reload successfully, preserving the newly created file.

Actual Behavior:

Instead of prompting the user to select a save location, the Workspace simply reloads, and the newly created file seems to have disappeared. If the user selects File -> Close Editor -> Save instead, Theia prompts the user to select a file location, which is the correct behavior.

Closing Workspace (bug):
bug - file saving from workplace

Closing Editor (correct):
normal file saving from closing editor

Steps to Reproduce:

  1. Remove AutoSave: File -> AutoSave
  2. Create new file from header: File -> New File or Alt+N
  3. Enter random content inside this new file which is unsaved
  4. Close the workspace and Save All: File -> Close Workspace -> Save All
  5. Theia will reload, select your previous workspace
  6. The unsaved file is gone even if the Save All option was selected

Additional Information

  • Operating System: Windows 11
  • Theia Version: 1.37.0
  • Tested on both browser and electron
@vince-fugnitto vince-fugnitto added bug bugs found in the application workspace issues related to the workspace labels May 24, 2023
vladarama added a commit to vladarama/theia that referenced this issue Jun 1, 2023
vladarama added a commit to vladarama/theia that referenced this issue Jun 1, 2023
vladarama added a commit to vladarama/theia that referenced this issue Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application workspace issues related to the workspace
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants