[vscode][proposed] Stub onWillCreateEditSessionIdentity #12533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcdumais-work
added
vscode
marcdumais-work
force-pushed
the
onWillCreateEditSessionIdentity
branch
4 times, most recently
from
e7b4dab
to
94d275f
Compare
tsmaeder
reviewed
May 16, 2023
vince-fugnitto
approved these changes
May 16, 2023
That's correct. I went a bit further than the simplest. I would not mind going with something simpler. |
marcdumais-work
force-pushed
the
onWillCreateEditSessionIdentity
branch
from
94d275f
to
f6cb9db
Compare
|
@tsmaeder as discussed I updated the 1st commit to use a separate Then I added commits on top to simplify the stub and tidy-up. |
|
I will resolve the conflicts locally after the other proposed API stubs are merged. |
|
@marcdumais-work it should be fine to rebase now 👍 |
This event was recently added to proposed API EditSessionIdentityProvider. For now we add a stub that will allow `[email protected]` and more recent to activate and be successfully used in Theia applications. Fixes #12521 Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
force-pushed
the
onWillCreateEditSessionIdentity
branch
from
011429c
to
7f631a3
Compare
Remove trailing space that trips the linter Co-authored-by: Vincent Fugnitto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This event was recently added to proposed API
EditSessionIdentityProvider. For now we add a stub that will allow[email protected]and more recent to activate and be successfully used in Theia applications.Fixes #12521
How to test
You can use the vscode.git 1.77.0 extensions below:
git-.zip
vscode.gitshould activate, not complaining aboutonWillCreateEditSessionIdentitynot existing. Built-ingitwill not ultimately work, unless@theia/gitis removed from the app - but that's no necessary for this PR)Review checklist
Reminder for reviewers