Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposed API][builtins] Theia misses part of proposed API: EditSessionIdentityProvider #12521

Closed
Tracked by #12518
marcdumais-work opened this issue May 11, 2023 · 0 comments · Fixed by #12533
Closed
Tracked by #12518
Assignees
Labels
builtins Issues related to VS Code builtin extensions git issues related to git vscode issues related to VSCode compatibility

Comments

@marcdumais-work
Copy link
Contributor

marcdumais-work commented May 11, 2023

Bug Description:

Or part thereof: workspace.onWillCreateEditSessionIdentity

Discovered while testing locally-built vscode built-in extensions 1.77.0, that resulted in a failed activation for vscode.git.

interesting part of the exception:

2023-05-10T18:47:09.885Z root ERROR [hosted-plugin: 2596234] Activating extension 'Git (built-in)' failed: TypeError: r.workspace.onWillCreateEditSessionIdentity is not a function

It looks like it's using a bit of proposed API: EditSessionIdentityProvider that we do not have yet.

Steps to Reproduce:

Use this extension after unzipping it into your plugins folder:
git-1.77.0.zip

Additional Information

Full exception:

2023-05-10T18:47:09.712Z root INFO [hosted-plugin: 2596234] PLUGIN_HOST(2596234): PluginManagerExtImpl/loadPlugin(/tmp/vscode-unpacked/git-1.77.0.vsix/extension/dist/main)
2023-05-10T18:47:09.885Z root ERROR [hosted-plugin: 2596234] Activating extension 'Git (built-in)' failed: TypeError: r.workspace.onWillCreateEditSessionIdentity is not a function
    at new t.GitEditSessionIdentityProvider (/tmp/vscode-unpacked/git-1.77.0.vsix/extension/dist/main.js:2:1424287)
    at S (/tmp/vscode-unpacked/git-1.77.0.vsix/extension/dist/main.js:2:1467662)
    at async A (/tmp/vscode-unpacked/git-1.77.0.vsix/extension/dist/main.js:2:1469905)
    at async t.activate (/tmp/vscode-unpacked/git-1.77.0.vsix/extension/dist/main.js:2:1470972)
    at async PluginManagerExtImpl.startPlugin (/home/lmcmcds/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:310:34)
    at async /home/lmcmcds/theia/packages/plugin-ext/lib/plugin/plugin-manager.js:219:21
  • Operating System:
  • Theia Version:
@marcdumais-work marcdumais-work added git issues related to git vscode issues related to VSCode compatibility builtins Issues related to VS Code builtin extensions labels May 11, 2023
@marcdumais-work marcdumais-work changed the title [proposed API][builtins] Theia misses proposed API: EditSessionIdentityProvider [proposed API][builtins] Theia misses part of proposed API: EditSessionIdentityProvider May 11, 2023
@marcdumais-work marcdumais-work self-assigned this May 12, 2023
marcdumais-work added a commit that referenced this issue May 15, 2023
…tSessionIdentity

This event has recently been added to vscode's version of this proposed API,
along with an implementation that we will not have at this time.

Fixes #12521

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit that referenced this issue May 15, 2023
This event was recently added to proposed API EditSessionIdentityProvider.
For now we go with a stub that will allow `[email protected]` and more recent
to activate and be used in Theia applications.

Fixes #12521

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit that referenced this issue May 15, 2023
This event was recently added to proposed API EditSessionIdentityProvider.
For now we add a stub that will allow `[email protected]` and more recent
to activate and be successfully used in Theia applications.

Fixes #12521

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit that referenced this issue May 15, 2023
This event was recently added to proposed API EditSessionIdentityProvider.
For now we add a stub that will allow `[email protected]` and more recent
to activate and be successfully used in Theia applications.

Fixes #12521

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit that referenced this issue May 15, 2023
This event was recently added to proposed API EditSessionIdentityProvider.
For now we add a stub that will allow `[email protected]` and more recent
to activate and be successfully used in Theia applications.

Fixes #12521

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit that referenced this issue May 15, 2023
This event was recently added to proposed API EditSessionIdentityProvider.
For now we add a stub that will allow `[email protected]` and more recent
to activate and be successfully used in Theia applications.

Fixes #12521

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit that referenced this issue May 15, 2023
This event was recently added to proposed API EditSessionIdentityProvider.
For now we add a stub that will allow `[email protected]` and more recent
to activate and be successfully used in Theia applications.

Fixes #12521

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit that referenced this issue May 16, 2023
This event was recently added to proposed API EditSessionIdentityProvider.
For now we add a stub that will allow `[email protected]` and more recent
to activate and be successfully used in Theia applications.

Fixes #12521

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit that referenced this issue May 18, 2023
This event was recently added to proposed API EditSessionIdentityProvider.
For now we add a stub that will allow `[email protected]` and more recent
to activate and be successfully used in Theia applications.

Fixes #12521

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit that referenced this issue May 19, 2023
This event was recently added to proposed API EditSessionIdentityProvider.
For now we add a stub that will allow `[email protected]` and more recent
to activate and be successfully used in Theia applications.

Fixes #12521

Signed-off-by: Marc Dumais <[email protected]>
tsmaeder pushed a commit to tsmaeder/theia that referenced this issue May 23, 2023
This event was recently added to proposed API EditSessionIdentityProvider.
For now we add a stub that will allow `[email protected]` and more recent
to activate and be successfully used in Theia applications.

Fixes eclipse-theia#12521

Signed-off-by: Marc Dumais <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins Issues related to VS Code builtin extensions git issues related to git vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant