-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git: add GitScmProvider.unstageAll
unit tests
#11806
git: add GitScmProvider.unstageAll
unit tests
#11806
Conversation
@Hanksha the |
@vince-fugnitto I fixed it, created an account and signed the ECA. I did this on behalf of Toro Cloud so I use that email to sign the commit this time. |
@vince-fugnitto Can you have a look at the test again? I changed it to use the actual Git implementation and a git repo on the filesystem. |
3f4b004
to
330eddc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new unit test looks good to me 👍
I merged the actual unstageAll
fix yesterday for yesterday's v1.31.0
release so you can rebase and squash locally first :)
Signed-off-by: Vivien Jovet <[email protected]>
2979b09
to
db2bb0e
Compare
@vince-fugnitto Done! By the way, isn't #11801 missing from CHANGELOG.md for 1.31.0? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
GitScmProvider.unstageAll
unit tests
What it does
Closes #11801.
This PR fixes the missing reset index option when calling unstage which is required to properly unstage all the staged changes. It also adds a unit test for it.
How to test
Review checklist
Reminder for reviewers
Signed-off-by: Vivien Jovet [email protected]