No pathspec error when using unstage all

[Hanksha]

Bug Description:

Whenever I use "Unstage All" in the Source Control view, via button (-) or the tab bar dropdown menu, I get this error: "fatal: No pathspec was given. Which files should I remove?"

Steps to Reproduce:

1. Create a directory
2. Run git init in that directory
3. Create a sample test.txt file
4. Open Theia with that directory as workspace
5. Go to Source Control view
6. Use the Unstage All via the button or tab bar dropdown menu

Note that it works fine to unstage a selected file or multiple selected files, it just does that with the unstage all command.

Additional Information

• Operating System: macOS and Windows
• Theia Version: 1.30

[vince-fugnitto]

@Hanksha I believe the same scenario will produce errors in vscode as well:

[Hanksha]

@vince-fugnitto Works fine in vscode for me:

Also there's already a master branch.

[vince-fugnitto]

@Hanksha would you like to contribute a fix?
I believe adding { reset: 'index' } works:

theia/packages/git/src/browser/git-scm-provider.ts

Line 322 in 7e753f4

await this.git.unstage(repository, uris);

async unstageAll(): Promise<void> {
    try {
        const { repository, stagedChanges } = this;
        const uris = stagedChanges.map(c => c.uri);
-        await this.git.unstage(repository, uris);
+        await this.git.unstage(repository, uris, { reset: 'index' });
    } catch (error) {
        this.gitErrorHandler.handleError(error);
    }
}

[Hanksha]

@vince-fugnitto Sure I will

[Hanksha]

@vince-fugnitto I just saw you did a PR, I was about to create mine. I added a unit test for it as well, do you want me to send it to you so you can add it to your PR?

[vince-fugnitto]

@vince-fugnitto I just saw you did a PR, I was about to create mine. I added a unit test for it as well, do you want me to send it to you so you can add it to your PR?

@Hanksha sorry I just didn't know when you'd be done and I wanted to get it in for the release, you can open yours and I'll review :)

[Hanksha]

@vince-fugnitto Alright, on it.