Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: fix unstage all #11805

Merged
merged 1 commit into from
Oct 27, 2022
Merged

git: fix unstage all #11805

merged 1 commit into from
Oct 27, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

Closes #11801.

The pull-request fixes unstage all which will now properly unstage the index rather than report errors, or discard changes.

unstage-all.mp4

How to test

  1. open a workspace under version control
  2. perform updates and add new files
  3. open the scm-view
  4. stage the individual changes
  5. confirm that unstage all properly unstages the changes

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

The commit fixes `unstage all` to properly reset the index rather than
report errors or discard changes.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added the git issues related to git label Oct 27, 2022
@vince-fugnitto vince-fugnitto self-assigned this Oct 27, 2022
Copy link
Contributor

@alvsan09 alvsan09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reproduced the problem and tested the fix works as per instructions 👍

The code LGTM as well !!
Thanks @vince-fugnitto !

@vince-fugnitto vince-fugnitto merged commit ca556c5 into master Oct 27, 2022
@vince-fugnitto vince-fugnitto deleted the vf/git-unstageAll branch October 27, 2022 18:24
@github-actions github-actions bot added this to the 1.31.0 milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git issues related to git
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No pathspec error when using unstage all
2 participants