Cleanup deprecated and out-dated authentication API #11564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-grant-work
approved these changes
Aug 11, 2022
Comment on lines
256
to
257
| private accounts = new Map<string, string[]>(); // Map account name to session ids | ||
| private sessions = new Map<string, string>(); // Map account id to name | ||
| private sessions = new Map<string, string>(); // Map account id to name |
There was a problem hiding this comment.
Maybe as a JSDoc so that it appears on hover for anyone working here in the future?
There was a problem hiding this comment.
Yeah, great idea, I fixed it!
Comment on lines
345
to
346
| .then(() => this.messageService.info('Successfully signed out.')) | ||
| .then(() => { }); |
There was a problem hiding this comment.
Suggested change
| .then(() => this.messageService.info('Successfully signed out.')) | |
| .then(() => { }); | |
| .then(() => { this.messageService.info('Successfully signed out.'); }) |
There was a problem hiding this comment.
Much better, thanks!
| $onDidChangeAuthenticationSessions(id: string, label: string): Promise<void> { | ||
| this.onDidChangeSessionsEmitter.fire({ provider: { id, label } }); | ||
| async $onDidChangeAuthenticationSessions(provider: theia.AuthenticationProviderInformation): Promise<void> { | ||
| this.onDidChangeSessionsEmitter.fire({ provider }); | ||
| return Promise.resolve(); |
There was a problem hiding this comment.
Can be deleted if the function is declared async.
There was a problem hiding this comment.
True, thank you!
- Remove very out-dated backwards compatibility to proposed VS Code API -- Get rid of provider id-based API -- Remove deprecated 'hasSession' from API -- Deprecate login/logout (now: createSession/removeSession) in Theia Previously we were compatible with a very specific commit of the proposed authentication API of VS Code 1.53.2. The API was moved from its proposed state to stable with 1.54.0 to which we are fully compatible. Relates to #11556
martin-fleck-at
force-pushed
the
issue-1156
branch
from
d6b12a5 to
3850a44
Compare
|
@colin-grant-work Thank you very much! I fixed the issues you mentioned and pushed an update. Should we merge this then or do you (or someone else) want to perform additional tests? |
|
@martin-fleck-at, I'm fine with merging, but if you'd like to request additional reviews, that is of course perfectly fine. |
vince-fugnitto
added
vscode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Previously we were compatible with a very specific commit of the proposed authentication API of VS Code 1.53.2. The API was moved from its proposed state to stable with 1.54.0 to which we are fully compatible even after this commit.
For a list of how the current compatibility came to be, please see #10709 (comment)
Relates to #11556
How to test
Check out commit https://github.com/martin-fleck-at/theia/tree/issue-1156-test which adds an authentication provider based on the stable API. We have commands that showcase the log in and log out of an account. This is basically an updated version of the testing strategy here: #10709
Review checklist
Reminder for reviewers