Clean Up theia.d.ts
#11493
Merged
Clean Up theia.d.ts
#11493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-grant-work
added
quality
colin-grant-work
force-pushed
the
bugfix/theia-d-ts-cleanup
branch
3 times, most recently
from
229f84a to
b5ea5c8
Compare
| * enables reusing existing code without migrating to a specific promise implementation. Still, | ||
| * we recommend the use of native promises which are available in this editor. | ||
| */ | ||
| interface Thenable<T> { |
There was a problem hiding this comment.
Isn't this type already defined in @theia/plugin? Is it necessary to re-declare it here?
There was a problem hiding this comment.
I'm open to suggestions. It could be declared only in theia.proposed.d.ts and then picked up automatically in theia.d.ts but it's good for it to be in theia.d.ts for the use of the comparator.
colin-grant-work
force-pushed
the
bugfix/theia-d-ts-cleanup
branch
2 times, most recently
from
a8a0027 to
12b6970
Compare
2 tasks
colin-grant-work
force-pushed
the
bugfix/theia-d-ts-cleanup
branch
from
dc56806 to
e1f0901
Compare
colin-grant-work
force-pushed
the
bugfix/theia-d-ts-cleanup
branch
from
8720d09 to
e3c5c19
Compare
colin-grant-work
force-pushed
the
bugfix/theia-d-ts-cleanup
branch
from
e3c5c19 to
ddfc055
Compare
vince-fugnitto
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #11564.
What it does
There are a number of syntactic (misplaced
readonlymodifiers) and semantic (use of undeclared variables) problems in ourtheia.d.tsfile. This cleans them up.We can detect these problems by setting
skipLibCheck: falseinpackages/plugin/tsconfig.json, but that makes it impossible to compile the application because we have a lot of conflicting declarations in our node modules.How to test
Review checklist
Reminder for reviewers