Standardized Plugins Downloads and Center Icons

[yiliang114]

fix(vsx-registry): Standardized Plugins Downloads and Center Icons
Signed-off-by: yiliang114 [email protected]

What it does

1. Standardized plugins downloads.
2. Downloads icon and reviews icon are not center a little, and it center icons of VSXExtensionsWidget.

How to test

1. Start application and turn Extensions activity bar.
2. Search something such as chinese.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

In VS Code, the downloads of extension is formatted with en-US and it endWiths k no matter what language is set. And the reviews number is always kept as an Int.

theia/packages/vsx-registry/src/browser/vsx-extension.tsx

Line 446 in 0c0f8c7

const downloadCompactFormatter = new Intl.NumberFormat(undefined, { notation: 'compact', compactDisplay: 'short' } as any);

But if theia uses undefined to new Intl.NumberFormat, it will cause language inconsistency when my browser default language is different from theia's default language.

After modification:

• As a reviewer, I agree to behave in accordance with the review guidelines

[yiliang114]

Why sometimes CI runs failed after long time? And if i try to rerun them which have ended with some errors, they are okey again.

[msujew]

@yiliang114 We have some flaky tests in there which sometimes (randomly) like to fail, usually related to file access which just times out. See #10348.

[msujew]

Thanks, the changes look good to me 👍

[yiliang114]

Referring to the format of vscode's Chinese translation, I added a Chinese translation to theia. Now its performance in Chinese and English is respectively

theia/packages/core/i18n/nls.zh-cn.json

Line 394 in f46789c

"averageRating": "平均评分：{0} 分(共 5 分)"

[msujew]

Hm, I just noticed that the translation workflow does not run on Forks, see #11525. I'll hope I can address this quickly, since merging it as it is would lead to problems later.

[vince-fugnitto]

The changes look good to me 👍 The new localizations will be added to the framework before the release as they do not work from a fork and we changed our approach.

[yiliang114]

The changes look good to me 👍 The new localizations will be added to the framework before the release as they do not work from a fork and we changed our approach.

Thank you both @msujew @vince-fugnitto