Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic translations not available for external contributions #11525

Closed
msujew opened this issue Aug 4, 2022 · 0 comments · Fixed by #11526
Closed

Automatic translations not available for external contributions #11525

msujew opened this issue Aug 4, 2022 · 0 comments · Fixed by #11526
Labels
ci issues related to CI / tests localization issues related to localization/internalization/nls

Comments

@msujew
Copy link
Member

msujew commented Aug 4, 2022

Bug Description:

When someone creates a PR based on a fork of Theia, the Automatic translation workflow doesn't run, leaving their work untranslated. This also leads to further issues down the line as soon as someone else tries to create a PR, as it will pick up the untranslated changes.

Steps to Reproduce:

  1. Fork Theia and create a new feature branch in the fork
  2. Add a new nls.localize key
  3. Create a PR, the Automatic translation workflow doesn't run

Additional Information

  • Operating System: GitHub
  • Theia Version: 1.28.0
@msujew msujew added ci issues related to CI / tests localization issues related to localization/internalization/nls labels Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issues related to CI / tests localization issues related to localization/internalization/nls
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant