core: remove maximize with double-click
#11279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
shell
vince-fugnitto
force-pushed
the
vf/tabbar-maximize
branch
from
859d1db to
3a82cef
Compare
|
Alternatively (as Colin mentioned offline), we could additionally control this behavior using a preference so we leave it up to the user to decide if they want to maximize using double-click or not. In order to align with the default behavior in VS Code I would make the preference off by default. |
|
In addition to preference gating, we could just leave the door open to easy customization by downstream applications. If we opt for that course, I think it would make sense to make the default implementation of the double click handler a no-op - in the current code, it's easier to override the double click handler than the method that adds the handler. |
vince-fugnitto
force-pushed
the
vf/tabbar-maximize
branch
from
cade872 to
72a0244
Compare
colin-grant-work
approved these changes
Jun 9, 2022
vince-fugnitto
force-pushed
the
vf/tabbar-maximize
branch
from
72a0244 to
4cabd6b
Compare
vince-fugnitto
force-pushed
the
vf/tabbar-maximize
branch
2 times, most recently
from
ded9e35 to
585a6a3
Compare
The commit adds support for the `workbench.tab.maximize` preference to control the behavior when double-clicking tabbars. By default the behavior is not to maximize the tab and align with the behavior found in vscode. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/tabbar-maximize
branch
from
585a6a3 to
a311bc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #5757.
The pull-request adds a new preference (
workbench.tab.maximize) to control the behavior of whether we want to maximize tabs when double clicking them (preference is set tofalseby default to align the behavior with vscode).How to test
workbench.tab.maximizeset tofalsethat tabs are not maximized when double clickingworkbench.tab.maximizeset totruethat tabs can be maximized using double clickReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]