core: remove maximize with double-click

The commit removes the problematic `maximize` functionality when performing a double-click of a tabbar. This behavior aligns with vscode. Signed-off-by: vince-fugnitto <[email protected]>
eclipse-theia · Jun 9, 2022 · 3a82cef · 3a82cef
1 parent 57f6415
commit 3a82cef
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -29,6 +29,8 @@
   [#11228](https://github.com/eclipse-theia/theia/pull/11228) - Contributed on behalf of STMicroelectronics.
 - [core] Drop support for Node 12.x, recommend Node 16.x.
   - Update CI/CD matrix to run on Node 14.x, 16.x and 18.x.
+- [core] removed handling that maximized tabbars when performing a double-click [#11279](https://github.com/eclipse-theia/theia/pull/11279)
+  - `handleDblClickEvent` in `tab-bars.ts` is deprecated.
 
 ## v1.26.0 - 5/26/2022
 

diff --git a/packages/core/src/browser/shell/tab-bars.ts b/packages/core/src/browser/shell/tab-bars.ts
@@ -152,7 +152,6 @@ export class TabBarRenderer extends TabBar.Renderer {
             {
                 key, className, id, title: title.caption, style, dataset,
                 oncontextmenu: this.handleContextMenuEvent,
-                ondblclick: this.handleDblClickEvent,
                 onauxclick: (e: MouseEvent) => {
                     // If user closes the tab using mouse wheel, nothing should be pasted to an active editor
                     e.preventDefault();
@@ -482,6 +481,10 @@ export class TabBarRenderer extends TabBar.Renderer {
         }
     };
 
+    /**
+     * @deprecated since 1.27.0.
+     * The framework no longer maximizes tabbars when performing a double-click.
+     */
     protected handleDblClickEvent = (event: MouseEvent) => {
         if (this.tabBar && event.currentTarget instanceof HTMLElement) {
             const id = event.currentTarget.id;