Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing StatusBarItem fields of VS Code API #11026

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Add missing StatusBarItem fields of VS Code API #11026

merged 2 commits into from
Apr 20, 2022

Commits on Apr 14, 2022

  1. Add missing StatusBarItem fields of VS Code API 

    * Add missing properties `id`, `name`, `backgroundColor` to `StatusBarItem` API
* Handle properties in implementation and forward to frontend
* Add backgroundColor handling to `StatusBar`
* In the plugin context, if no status bar item id is given, do NOT  use the extension id as specified in the VS Code API.
  Instead, keep the current logic of generating a unique id.

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <[email protected]>
    @lucas-koehler
    lucas-koehler committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    8de4ba3 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. core: register additional statusbar colors 

    The commit registers the following theming colors for statusbar items:
- `statusBarItem.errorBackground`
- `statusBarItem.errorForeground`
- `statusBarItem.warningBackground`
- `statusBarItem.warningForeground`

Signed-off-by: vince-fugnitto <[email protected]>
    @vince-fugnitto @lucas-koehler
    vince-fugnitto authored and lucas-koehler committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    f7a72d6 View commit details
    Browse the repository at this point in the history