Add missing StatusBarItem fields of VS Code API

[lucas-koehler]

What it does

Fixes #11019

• Add missing properties id, name, backgroundColor to StatusBarItem API
• Handle properties in implementation and forward to frontend
• Add backgroundColor handling to StatusBar
• In the plugin context, if no status bar item id is given, do NOT use the extension id as specified in the VS Code API.
  Instead, keep the current logic of generating a unique id.

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler [email protected]

status-bar-item-properties.mp4

How to test

• Download the test extension from here. The source is available here for reference.
• Select Theia Light theme
• Open a text file and select a few lines. For line count zero, the error colors should be used, for one or two the text should have color blue (#0000FF), for 3 or more lines the warning colors should be used
• Click on the status bar entry.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

Adapt Theia's light theme in your repository to have warning and error colors because the theme's in Theia do not have them, yet: Add to packages/monaco/data/monaco-themes/vscode/light_theia.json to colors property:

"statusBarItem.errorBackground": "#c72e0f",
"statusBarItem.warningBackground": "#c7b50f",
"statusBarItem.errorForeground": "#ffffff",
"statusBarItem.warningForeground": "#000"

@lucas-koehler given that the changes rely on the following theming colors, part of the changes should be to register the defaults for these theming colors (so even if a theme does not set them they still work):

• be804aa

[lucas-koehler]

@vince-fugnitto Thanks for the feedback! I agree that it makes sense to add default colors. I cherry-picked and tested your commit. Is that alright with you?

[msujew]

The changes look good to me. I can confirm that the extension performs as expected 👍

@vince-fugnitto anything to add?

[vince-fugnitto]

@vince-fugnitto Thanks for the feedback! I agree that it makes sense to add default colors. I cherry-picked and tested your commit. Is that alright with you?

Of course, I tried to make it easy for you to consume :)

[vince-fugnitto]

I also confirm that the changes work well using the example plugin 👍