electron: Fix path comparison for exit confirmation #10597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
added
electron
There was a problem hiding this comment.
Looks reasonable to me, but I'm temporarily without a Windows environment for testing. @vince-fugnitto, @paul-marechal, are you able to run in Windows?
msujew
force-pushed
the
msujew/fix-electron-exit-win
branch
from
adcd054 to
97029e7
Compare
msujew
force-pushed
the
msujew/fix-electron-exit-win
branch
from
97029e7 to
78da47e
Compare
paul-marechal
approved these changes
Jan 5, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #10596
Before testing for
includes, we replace all backwards slashes with forward slashes.How to test
application.confirmExitpreference toalways.Review checklist
Reminder for reviewers