Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron window does never confirm exit (Windows) #10596

Closed
msujew opened this issue Jan 5, 2022 · 0 comments · Fixed by #10597
Closed

Electron window does never confirm exit (Windows) #10596

msujew opened this issue Jan 5, 2022 · 0 comments · Fixed by #10597
Labels
bug bugs found in the application electron issues related to the electron target OS/Windows issues related to the Windows OS

Comments

@msujew
Copy link
Member

msujew commented Jan 5, 2022

Bug Description:

#10379 introduces a check for the "main window" by comparing the current web content URL and the main html page:

const safeToClose = !electronWindow.webContents.getURL().includes(this.globals.THEIA_FRONTEND_HTML_PATH) || await this.checkSafeToStop(electronWindow, reason);

However, this check fails on windows, since getURL() returns a URI path with forward slashes, while THEIA_FRONTEND_HTML_PATH uses backward slashes on windows.

Steps to Reproduce:

  1. Start the electron app on Windows
  2. Set the application.confirmExit preference to always
  3. Exit the app, no confirmation dialog is displayed

Additional Information

  • Operating System: Windows
  • Theia Version: 1.21.0
@msujew msujew added bug bugs found in the application electron issues related to the electron target OS/Windows issues related to the Windows OS labels Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application electron issues related to the electron target OS/Windows issues related to the Windows OS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant