Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export interfaces to aid extension in ProcessTaskRunner #10547

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

colin-grant-work
Copy link
Contributor

What it does

A follow on to #10392. Breaking down the methods is good, but extenders can't use the interfaces introduced by the refactor if they're not exported. Oops.

How to test

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added the extensibility issues to simplify ability to extend Theia label Dec 15, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@colin-grant-work colin-grant-work merged commit 6175dfa into master Dec 15, 2021
@colin-grant-work colin-grant-work deleted the minor/export-ptr-interfaces branch December 15, 2021 22:49
@github-actions github-actions bot added this to the 1.21.0 milestone Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensibility issues to simplify ability to extend Theia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants