Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to improve extensibility of ProcessTaskRunner #10392

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

colin-grant-work
Copy link
Contributor

What it does

Addresses (but doesn't fix) #8164 by making it easier to override specific parts of the getResolvedCommand procedure.

How to test

  1. This should introduce no changes in run-time behavior.
  2. You should be able to run the same tasks in the same way as before.

Review checklist

Reminder for reviewers

Signed-off-by: Colin Grant [email protected]

Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactoring looks good, just a few comments.

packages/task/src/node/process/process-task-runner.ts Outdated Show resolved Hide resolved
packages/task/src/node/process/process-task-runner.ts Outdated Show resolved Hide resolved
@vince-fugnitto vince-fugnitto added extensibility issues to simplify ability to extend Theia tasks issues related to the task system labels Nov 8, 2021
@colin-grant-work colin-grant-work force-pushed the feature/process-task-runner-extensibility branch from ea6176e to bc10ce4 Compare November 17, 2021 17:19
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@colin-grant-work colin-grant-work merged commit 07aacaa into master Nov 18, 2021
@colin-grant-work colin-grant-work deleted the feature/process-task-runner-extensibility branch November 18, 2021 00:01
@github-actions github-actions bot added this to the 1.20.0 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensibility issues to simplify ability to extend Theia tasks issues related to the task system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants