Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect preference value for editor.renderWhitespace fixed typo #10317

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

yashsoni369
Copy link
Contributor

@yashsoni369 yashsoni369 commented Oct 22, 2021

What it does

Fixes #10316 by changing the typo in editor.renderWhitespace from trailin to trailing

How to test

Test steps are similar to #10316 issue.

  1. start the application
  2. set the preference for editor.renderWhitespace to trailing
  3. trailing whitespaces are visible

Review checklist

Reminder for reviewers

Signed-off-by: Yash Soni [email protected]

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

@vince-fugnitto vince-fugnitto added editor issues related to the editor preferences issues related to preferences labels Oct 22, 2021
@yashsoni369
Copy link
Contributor Author

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

Done

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me 👍
I confirmed the value is correct and the preference now works for trailing whitespaces:

image

Thank you for your first contribution to the project!

@vince-fugnitto vince-fugnitto added this to the 1.19.0 milestone Oct 22, 2021
@vince-fugnitto vince-fugnitto merged commit c3caca6 into eclipse-theia:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor issues related to the editor preferences issues related to preferences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editor: fix incorrect preference value for editor.renderWhitespace
2 participants