Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor: fix incorrect preference value for editor.renderWhitespace #10316

Closed
vince-fugnitto opened this issue Oct 22, 2021 · 1 comment · Fixed by #10317
Closed

editor: fix incorrect preference value for editor.renderWhitespace #10316

vince-fugnitto opened this issue Oct 22, 2021 · 1 comment · Fixed by #10317
Labels
beginners issues that are perfect for beginners bug bugs found in the application editor issues related to the editor good first issue good first issues for new contributors preferences issues related to preferences

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

Following #10106, the preference value for editor.renderWhitespace is incorrect.

theia/packages/editor/src/browser/editor-preferences.ts

Line 1025 in c12d1ef

'trailin',

trailin should be updated to trailing as it is not a valid value.

Steps to Reproduce:

  1. confirm the typo
  2. start the application
  3. set the preference for editor.renderWhitespace to trailin
  4. confirm that the preference does not work - trailing whitespaces are not visible
@vince-fugnitto vince-fugnitto added bug bugs found in the application preferences issues related to preferences editor issues related to the editor beginners issues that are perfect for beginners good first issue good first issues for new contributors labels Oct 22, 2021
@yashsoni369 yashsoni369 mentioned this issue Oct 22, 2021
Merged
1 task
@yashsoni369
Copy link
Contributor

Fixed and created PR #10317 . Please update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginners issues that are perfect for beginners bug bugs found in the application editor issues related to the editor good first issue good first issues for new contributors preferences issues related to preferences
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

incorrect preference value for editor.renderWhitespace fixed typo yashsoni369/theia
2 participants
@yashsoni369 @vince-fugnitto