use ReadonlyArray for DocumentSelector #10070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@smart-bo thank you for the pull-request 👍
Please be sure to properly sign the eclipse contributor agreement (eca) with the same email as your authorship so we can accept your changes.
vince-fugnitto
approved these changes
Sep 9, 2021
tsmaeder
reviewed
Sep 10, 2021
| ({ | ||
| range: fromRange(r)! | ||
| })); | ||
| ({ |
There was a problem hiding this comment.
This is not the formatting the typescript formatter creates. Let's stick to that unless there is a compelling reason.
There was a problem hiding this comment.
Do you have directions on how to set this up? VS Code formats like this.
There was a problem hiding this comment.
@paul-marechal it doesn't for me 🤷
RomanNikitenko
pushed a commit
that referenced
this pull request
Sep 16, 2021
RomanNikitenko
pushed a commit
that referenced
this pull request
Sep 16, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Change
Array<DocumentFilter>toReadonlyArray<DocumentFilter>at:theia/packages/plugin/src/theia.d.tsFix #10025
How to test
N/A
Review checklist
Reminder for reviewers