Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocumentSelector Should use read-only array of DocumentFilter #10025

Closed
Tracked by #9863
tsmaeder opened this issue Sep 1, 2021 · 0 comments · Fixed by #10070
Closed
Tracked by #9863

DocumentSelector Should use read-only array of DocumentFilter #10025

tsmaeder opened this issue Sep 1, 2021 · 0 comments · Fixed by #10070
Labels
good first issue good first issues for new contributors vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Sep 1, 2021 •
edited by vince-fugnitto
Loading

Feature Description:

DocumentSelector Should use read-only array of DocumentFilter.

theia/packages/plugin/src/theia.d.ts

Line 6157 in 068e78d

export type DocumentSelector = DocumentFilter | string | Array<DocumentFilter | string>;

Just change the definition to ReadonlyArray<DocumentFilter> like so:

export type DocumentSelector = DocumentFilter | string | ReadonlyArray<DocumentFilter | string>;
@tsmaeder tsmaeder added good first issue good first issues for new contributors vscode issues related to VSCode compatibility labels Sep 1, 2021
@tsmaeder tsmaeder mentioned this issue Sep 1, 2021
Closed
48 tasks
@smart-bo smart-bo mentioned this issue Sep 8, 2021
Merged
1 task
smart-bo added a commit to smart-bo/theia that referenced this issue Sep 8, 2021
@smart-bo
fix errors from eclipse-theia#10025
1ad9b1e
tsmaeder pushed a commit that referenced this issue Sep 14, 2021
@smart-bo
use ReadonlyArray for DocumentSelector (#10070)
8df74a7 
fixes #10025
RomanNikitenko pushed a commit that referenced this issue Sep 16, 2021
@smart-bo @RomanNikitenko
use ReadonlyArray for DocumentSelector (#10070)
5a3f0b8 
fixes #10025
RomanNikitenko pushed a commit that referenced this issue Sep 16, 2021
@smart-bo @RomanNikitenko
use ReadonlyArray for DocumentSelector (#10070)
a86a9e4 
fixes #10025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue good first issues for new contributors vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use ReadonlyArray for DocumentSelector smart-bo/theia
1 participant
@tsmaeder