Add deprecated fields to LanguageConfiguration #10050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dineshUmasankar thanks for taking care of this. I guess we can relax the testing requirements on Theia ignoring two optional fields ;-) |
|
@tsmaeder For future reference, how would I go about testing fields in Theia? |
|
@dineshUmasankar Usually, you would use/write a vscode extension that makes use of whatever you add to the |
|
There are also many samples that can be useful for testing here: https://github.com/Microsoft/vscode-extension-samples |
RomanNikitenko
pushed a commit
that referenced
this pull request
Sep 16, 2021
RomanNikitenko
pushed a commit
that referenced
this pull request
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Handling issue: #10031
There are two deprecate fields __electricCharacterSupport and __characterPairSupport in LanguageConfiguration.
I added these declarations into theia.d.ts and ensured they were marked with deprecation annotations.
As #10031 stated, I only added declarations for support but did not pursue implementation.
How to test
I require help with testing the existence of fields within interfaces. Would I write up a test inside of the respective
package.spec.ts?Review checklist
Reminder for reviewers