Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecated fields to LanguageConfiguration #10031

Closed
Tracked by #9863
tsmaeder opened this issue Sep 1, 2021 · 2 comments
Closed
Tracked by #9863

Add deprecated fields to LanguageConfiguration #10031

tsmaeder opened this issue Sep 1, 2021 · 2 comments
Labels
good first issue good first issues for new contributors vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Sep 1, 2021

Feature Description:

There are two deprecate fields __electricCharacterSupport and __characterPairSupport in LanguageConfiguration. We should add the declarations for compatibility, but not an implementation.

https://code.visualstudio.com/api/references/vscode-api#LanguageConfiguration
@tsmaeder tsmaeder added good first issue good first issues for new contributors vscode issues related to VSCode compatibility labels Sep 1, 2021
@tsmaeder tsmaeder mentioned this issue Sep 1, 2021
Closed
48 tasks
@dineshUmasankar
Copy link
Contributor

I would like to submit my attempt on this issue. I believe I would be adding these two fields into the interface defined as LanguageConfiguration. In addition, I am not entirely sure how to test fields within an interface, and would appreciate some guidance regarding this.

@dineshUmasankar dineshUmasankar mentioned this issue Sep 4, 2021
Merged
1 task
@vince-fugnitto
Copy link
Member

Closing thanks to #10050 👍
@dineshUmasankar in the future you can use the following syntax to automatically close issues when pull-requests are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue good first issues for new contributors vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tsmaeder @vince-fugnitto @dineshUmasankar