Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update task schema according to installed extensions/plugins #6485

Closed
RomanNikitenko opened this issue Nov 4, 2019 · 9 comments · Fixed by #6492
Closed

Update task schema according to installed extensions/plugins #6485

RomanNikitenko opened this issue Nov 4, 2019 · 9 comments · Fixed by #6492
Assignees
@elaihau
Labels
enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system

Comments

@RomanNikitenko
Copy link
Contributor

RomanNikitenko commented Nov 4, 2019 •
edited
Loading

Description

Task schema should be updated according to installed extensions/plugins.

Task types support for installed plugins is coming with the PR from @elaihau - thank you very much!
Would be nice to support other fields of task configurations.

Reproduction Steps

  1. Install npm vs code extension
  2. Open tasks.json file
  3. Start to create a new configuration: "type": "npm",
  4. Press Ctrl + space = > you can see that expected script field is absent in the list of the suggestions.

Expected behavior:
vs code displays the filed:
script_vscode

and warning:
warning_npm

I tested the same behavior for typescript task:
tsc_warning

OS and Theia version:
Ubuntu 18.04.1
Theia version: 05f2e07bb77637723e6720231342b9accesta01a159
@RomanNikitenko RomanNikitenko added enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system labels Nov 4, 2019
@elaihau elaihau self-assigned this Nov 4, 2019
@elaihau
Copy link
Contributor

elaihau commented Nov 4, 2019

I can resolve this one as the first step of fixing #6482

@elaihau elaihau mentioned this issue Nov 4, 2019
Merged
1 task
elaihau pushed a commit that referenced this issue Nov 5, 2019
update task schema for Theia extensions & plugins
d6b3ab6 
- With this change, Theia processes task definitions contributed by extensions and plugins, and updates the task schema.- resolves #6485

Signed-off-by: Liang Huang <[email protected]>
@elaihau elaihau mentioned this issue Nov 5, 2019
Merged
1 task
elaihau pushed a commit to elaihau/theia that referenced this issue Nov 6, 2019
update task schema for Theia extensions & plugins
39ea9f1 
- With this change, Theia processes task definitions contributed by extensions and plugins, and updates the task schema.- resolves eclipse-theia#6485

Signed-off-by: Liang Huang <[email protected]>
@ShimonBenYair
Copy link
Contributor

ShimonBenYair commented Nov 6, 2019 •
edited
Loading

@elaihau

i have took your change, installed eslint and npm vs code extension in my theia/plgins folder.
But it fails to recognize a task of type "npm" , see screenshots :
npm_installed_plugin
npm_type_not_dispaly

npm_error

@elaihau
Copy link
Contributor

elaihau commented Nov 6, 2019 •
edited
Loading

@ShimonBenYair
Thank you for the review !
I guess we installed different vs code extensions, my "plugins view" looks like this:

Screenshot from 2019-11-06 07-09-25

@akosyakov
Copy link
Member

@elaihau It would be helpful it you provide how to install correct VS Code extensions.

@ShimonBenYair
Copy link
Contributor

ShimonBenYair commented Nov 6, 2019 •
edited
Loading

@elaihau @RomanNikitenko
Thanks for the answer.
can you write the link for the npm extension you installed ?

elaihau pushed a commit that referenced this issue Nov 7, 2019
update task schema for Theia extensions & plugins
3ba3520 
- With this change, Theia processes task definitions contributed by extensions and plugins, and updates the task schema.
- resolves #6485

Signed-off-by: Liang Huang <[email protected]>
@RomanNikitenko
Copy link
Contributor Author

@ShimonBenYair
I use these extensions for testing

elaihau pushed a commit that referenced this issue Nov 7, 2019
@elaihau
update task schema for Theia extensions & plugins
c26f35d 
- With this change, Theia processes task definitions contributed by extensions and plugins, and updates the task schema.
- resolves #6485

Signed-off-by: Liang Huang <[email protected]>
@ShimonBenYair
Copy link
Contributor

ShimonBenYair commented Nov 16, 2019 •
edited
Loading

@elaihau @RomanNikitenko

I can't build this project ( always get the error :"spawn e2big")
can you please attach here the correct VS Code extensionsthe (.vsix files) as zip file ?

Thanks
Shimon

@elaihau
Copy link
Contributor

elaihau commented Nov 18, 2019

@ShimonBenYair
These are the ones I copied into the theia/plugins - you don't need to compile them.
vs_extensions.zip

Could you please confirm if you can use them?

@ShimonBenYair
Copy link
Contributor

@elaihau

I can use them successfully.
Thanks a lot

akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
update task schema for Theia extensions & plugins
d858f08 
- With this change, Theia processes task definitions contributed by extensions and plugins, and updates the task schema.
- resolves eclipse-theia#6485

Signed-off-by: Liang Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elaihau elaihau

Labels
enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update task schema for installed extensions & plugins eclipse-theia/theia
4 participants
@akosyakov @RomanNikitenko @ShimonBenYair @elaihau