Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task config parsing errors are not handled properly #6482

Closed
elaihau opened this issue Nov 2, 2019 · 0 comments · Fixed by #6515
Closed

task config parsing errors are not handled properly #6482

elaihau opened this issue Nov 2, 2019 · 0 comments · Fixed by #6515
Assignees
@elaihau
Labels
bug bugs found in the application tasks issues related to the task system

Comments

@elaihau
Copy link
Contributor

elaihau commented Nov 2, 2019

Description

In the current version of Theia, the invalid task configs from tasks.json, although not successfully parsed, are still added to the list of tasks.

Theia should handle those errors properly.

Reproduction Steps

Peek 2019-11-01 23-09

  • add an invalid task config to tasks.json - it could be as simple as an empty object { }
  • pull out the task list from the top menu bar "Terminal" -> "Run Task"

Expected: the invalid task should be hidden from the user
What happened: undefined: undefined shows up in the list of tasks

OS and Theia version:

Ubuntu 18.04. Example browser
Version 05f2e07
@elaihau elaihau added bug bugs found in the application tasks issues related to the task system labels Nov 2, 2019
@RomanNikitenko RomanNikitenko mentioned this issue Nov 2, 2019
Merged
2 tasks
@elaihau elaihau self-assigned this Nov 2, 2019
elaihau pushed a commit that referenced this issue Nov 4, 2019
update task schema for the detected tasks
147b3e7 
- With this change, Theia updates the task schema on task definitions
are registered & unregistered. And users get content assist while they
enter task configs in the editor.
- first step of #6482

Signed-off-by: Liang Huang <[email protected]>
This was referenced Nov 4, 2019
Closed
Merged
elaihau pushed a commit that referenced this issue Nov 8, 2019
handles invalid task configurations
5a7ded5 
- not display the invalid task configurations in the list of tasks.
- displays a warning message to inform users if Theia finds invalid task
configuration(s) in tasks.json.
- fixes #6482

Signed-off-by: Liang Huang <[email protected]>
@elaihau elaihau mentioned this issue Nov 8, 2019
Merged
1 task
elaihau pushed a commit that referenced this issue Nov 8, 2019
handles invalid task configurations
e3dafbf 
- not display the invalid task configurations in the list of tasks.
- displays a warning message to inform users if Theia finds invalid task
configuration(s) in tasks.json.
- fixes #6482

Signed-off-by: Liang Huang <[email protected]>
elaihau pushed a commit that referenced this issue Nov 8, 2019
handles invalid task configurations
1166ec9 
- not display the invalid task configurations in the list of tasks.
- displays a warning message to inform users if Theia finds invalid task
configuration(s) in tasks.json.
- fixes #6482

Signed-off-by: Liang Huang <[email protected]>
elaihau pushed a commit that referenced this issue Nov 8, 2019
handles invalid task configurations
0912e85 
- not display the invalid task configurations in the list of tasks.
- displays a warning message to inform users if Theia finds invalid task
configuration(s) in tasks.json.
- fixes #6482

Signed-off-by: Liang Huang <[email protected]>
elaihau pushed a commit that referenced this issue Nov 8, 2019
handles invalid task configurations
e272f70 
- not display the invalid task configurations in the list of tasks.
- displays a warning message to inform users if Theia finds invalid task
configuration(s) in tasks.json.
- fixes #6482

Signed-off-by: Liang Huang <[email protected]>
elaihau pushed a commit that referenced this issue Nov 12, 2019
handles invalid task configurations
b942c02 
- not display the invalid task configurations in the list of tasks.
- displays a warning message to inform users if Theia finds invalid task
configuration(s) in tasks.json.
- fixes #6482

Signed-off-by: Liang Huang <[email protected]>
elaihau pushed a commit that referenced this issue Nov 12, 2019
handles invalid task configurations
9a3b5c2 
- not display the invalid task configurations in the list of tasks.
- displays a warning message to inform users if Theia finds invalid task
configuration(s) in tasks.json.
- fixes #6482

Signed-off-by: Liang Huang <[email protected]>
elaihau pushed a commit that referenced this issue Nov 12, 2019
handles invalid task configurations
51b011d 
- not display the invalid task configurations in the list of tasks.
- displays a warning message to inform users if Theia finds invalid task
configuration(s) in tasks.json.
- fixes #6482

Signed-off-by: Liang Huang <[email protected]>
elaihau pushed a commit that referenced this issue Nov 12, 2019
handles invalid task configurations
35aebc1 
- not display the invalid task configurations in the list of tasks.
- displays a warning message to inform users if Theia finds invalid task
configuration(s) in tasks.json.
- fixes #6482

Signed-off-by: Liang Huang <[email protected]>
elaihau pushed a commit that referenced this issue Nov 12, 2019
@elaihau
handles invalid task configurations
fb398d6 
- not display the invalid task configurations in the list of tasks.
- displays a warning message to inform users if Theia finds invalid task
configuration(s) in tasks.json.
- fixes #6482

Signed-off-by: Liang Huang <[email protected]>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
handles invalid task configurations
69d5aef 
- not display the invalid task configurations in the list of tasks.
- displays a warning message to inform users if Theia finds invalid task
configuration(s) in tasks.json.
- fixes eclipse-theia#6482

Signed-off-by: Liang Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elaihau elaihau

Labels
bug bugs found in the application tasks issues related to the task system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handles invalid task configurations eclipse-theia/theia
1 participant
@elaihau