-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repo: update license and headers #73
Conversation
@vince-fugnitto the README still mentions Apache 2.0 license. You should probably use the same blurb we have in the main repo, that also covers the Theia trademark as well. |
I notice that the |
4baa7d5
to
107f0ca
Compare
Thank you! The
The |
I though it might be something like that. Makes sense I think, in this particular case. |
Last thing I noticed: I think it would be good to give a bit of context in the commit message, about why this is being done. e.g. mention the move of the repo to the Foundation: https://github.com/theia-ide/vscode-builtin-extensions/pull/36/commits update: can you, as for |
107f0ca
to
8eb421f
Compare
The commit includes the following updates which are prerequisites for moving the repository under the eclipse foundation: - updates the repository `license` (license file and `package.json` entry). - updates the headers of source code, - includes the header snippet to easily add new licenses. See here for motivation: [motivation](#60) See here for details: [details](https://github.com/theia-ide/generator-theia-extension/wiki/Re-licensing-theia-ide-generator-theia-extension) Signed-off-by: vince-fugnitto <[email protected]>
8eb421f
to
8405eed
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @vince-fugnitto !
Thanks vince! |
I think the re-licensing exercise for this repo is all done! I have updated the wiki accordingly: I think we can merge this PR. Thanks @JonasHelming and @vince-fugnitto |
Description
The commit includes the following updates which are prerequisites for
moving the repository under the eclipse foundation:
license
(license file andpackage.json
entry).
See here for motivation: motivation
See here for details: details
Signed-off-by: vince-fugnitto [email protected]