proposal: Re-license repository, move it repository under 'eclipse-theia'

[vince-fugnitto]

Description

The proposal is to move the repository under the eclipse-theia organization. Moving the repository can potentially increase visibility and also welcome additional contributions and contributors. One issue with moving might be re-licensing the repository.

Would anyone object to moving the repo?

cc @marcdumais-work @svenefftinge @akosyakov

[akosyakov]

It sounds fine with me. There was also this issue: eclipse-theia/theia#7387 to reduce maintenance. Another thing to consider it could be worth to turn it into application generator so we can support different layouts, i.e. developing VS Code extension against Theia, Theia extension, mix of them or just generate an app for one of platforms. Right now it is not easy to setup.

[JonasHelming]

About the "developing VS Code extension against Theia": I totally like this idea, and I would be happy to contribute that. However, we should not forget about: https://github.com/eclipse/theia-generator-plugin

So the VS Code extension template would rather fit into the plugin generator, wouldn't it? Or maybe, we even want to merge the two generators mid-term?

[marcdumais-work]

cc: @benoitf

[benoitf]

repositories theia-generator-plugin and theia-plugin-packager can be moved from eclipse to eclipse-theia

[marcdumais-work]

One thing to keep in mind is that we will need to re-license this repo before the move, from Apache 2 to probably EPL 2. We've done the same for the main repo a while ago and it's not necessarily easy: we need to get permission from every contributor or copyright holder when not the same. If not possible for some of the commits, the alternative is to remove them.

Other than the "usual suspects" I see a few contributor's names I do not immediately recognize:
https://github.com/theia-ide/generator-theia-extension/graphs/contributors

[JonasHelming]

I obviously agree to the re-licensing, The Zoker will (he is affiliated with us), therrance only changed a version number (we could revert if he does not agree) and vazexqi change a tsconfig file (same)

[marcdumais-work]

I obviously agree to the re-licensing, The Zoker will (he is affiliated with us), therrance only changed a version number (we could revert if he does not agree) and vazexqi change a tsconfig file (same)

Thanks Jonas for having a closer look - re-licensing may not be so hard after all. Note however that in some cases like for Vince and myself, our employer is the copyright owner of our contributions and we'll need to escalate internally to obtain such a permission officially. It could be the case for others as well. Still, this is not an insurmountable obstacle.

(I think I only appear as contributor here because I have done some releases, so this applies mostly for Vince I think)

[JonasHelming]

Perfectly understood, I am personally authorized to give this permission for me and the Zoker

[marcdumais-work]

So the VS Code extension template would rather fit into the plugin generator, wouldn't it?

@benoitf would you welcome this contribution?

repositories theia-generator-plugin and theia-plugin-packager can be moved from eclipse to eclipse-theia

I understand you would be in favor of merging the two genarator?

[benoitf]

@marcdumais-work well when we started the plugin generator we asked if we could add it to the extension generator and it was decided that it was not a good way to mix two concepts...

Also it's not interesting to have the extension generator when you're on a running Theia as you can't add any extension at runtime so I'm unsure it's a good way to merge them.

[marcdumais-work]

@marcdumais-work well when we started the plugin generator we asked if we could add it to the extension generator and it was decided that it was not a good way to mix two concepts...

Also it's not interesting to have the extension generator when you're on a running Theia as you can't add any extension at runtime so I'm unsure it's a good way to merge them.

Ok, makes sense, thanks @benoitf . So probably merging the two generator together may not be so useful or at least debatable.

What about a having the VS Code extension template contributed to the plugin generator, as proposed by @JonasHelming?

[benoitf]

What about a having the VS Code extension template contributed to the plugin generator, as proposed by @JonasHelming?

@marcdumais-work it may be cool but I'm not sure to see the benefits ?
Like using .theia packaging but with VS Code api ? or generating vsix files with VS Code API ? in that case, what are the difference with VS Code generator ?

BTW if we have several generators, yeoman is prompting you which one you want to pickup.

[JonasHelming]

To avoid any misunderstandings: The VS Code extension template was proposed by @akosyakov (although I like the idea). I proposed to put it into the plugin generator rather than here.
So maybe @akosyakov can give feedback to your questions.

[benoitf]

I would like to have an example on having VS Code extension with using both Theia and VS Code and other namespaces but IMHO it's not yet possible. (As we change the target namespace for now)

[akosyakov]

For our customers we have setups with Theia + VS Code extensions, i.e. VS Code extensions bring language and debug support, Theia extensions restyle, rebrand UI brings new views, they communicate via generic commands. VS Code extensions then used in VS Code with limited functionality. As soon as we drop the monaco-languageclient, such setups will be normal. I have not seen in practice Theia plugins besides in Che.

We could also think about composing different generators: https://yeoman.io/authoring/composability.html

what are the difference with VS Code generator ?

VS Code generator does not configure Theia applications to load generated extensions

[JonasHelming]

OK, let us summerize the discussion above, I think there are the followng proposals:

1. Move this repo under eclipse-theia
2. Move the content into the main repo (repo: move generators inside main repo theia#7387)
3. Merge extension and plugin generator or combine using composition
4. Provide a new VS Code like template

I think there is agreement on "1." and that is what this issue is actually about, so I think it makes sense to do this first. So is there something to help with to complete 1.?

[JonasHelming]

Any news on this? Again please let me know, if I can assist you with anything...

[marcdumais-work]

Hi @JonasHelming ,

As discussed offline we'll go ahead with step one for the 3 repos, or let's say step 0.5 - Sharon confirmed we'll need to re-license each repo first, to match the Eclipse Theia license. I'm hoping you can help with getting contributors permissions and potentially removing/replacing contributions we can't re-license, for this repo and theia-ide/theia-website. I'll take care of theia-ide/vscode-builtin-extensions, that I added to the list :)

I am working on documenting each of the 3 repo's contributions and sorting-out who we need to get permission-from.
It should not be too bad. I'll add a "re-licensing" or such page on each repo with this info, shortly.

Ref:

• Re-license this repo to match Eclipse Theia, contribute it to project vscode-builtin-extensions#16
• Proposal: Re-license repo, Move theia-ide web site to eclipse-theia theia-website#122

[JonasHelming]

Hi @marcdumais-work ,

yes I can certainly do that. Please ping me, when the document is in place (you can probably use https://github.com/eclipse-theia/theia/wiki/Theia-Re-Licensing) as a template.

[marcdumais-work]

Hi @JonasHelming ,

I created a wiki to track the re-licensing of this repo: https://github.com/theia-ide/generator-theia-extension/wiki/Re-licensing-theia-ide-generator-theia-extension

I created one as well for theia-website: https://github.com/theia-ide/theia-website/wiki/Re-licensing-theia-ide-theia-website

Please feel free to double-check that I have not missed any contribution or made mistakes. I will contact you by email to discuss how the permissions should be obtained.

[marcdumais-work]

@benoitf can you guide us about how to obtain Red Hat's permission to re-license your and Artem's contributions in this repo and in theia-website?

For Ericsson and TypeFox, we'll provide an Eclipse Foundation-approved "verbiage" that needs to be approved by someone in the company who has power to do so and sent back to the Foundation. Do you think it's also the way to go for your company's contributions?

cc: @JonasHelming

[richardfontana]

@marcdumais-work I'm a Red Hat lawyer with responsibility for open source - Red Hat authorizes relicensing any Red Hat contributions in this repo and theia-website to EPL 2.0. (As far as I can tell from this comment thread that is the desired license change.)

[marcdumais-work]

Hi @richardfontana . Thanks for getting back to us so quickly!

The Eclipse Foundation has requested that re-licensing permission be confirmed by email, sent directly to them by someone in the position to provide said permission. If you'll be kind enough to give us an email address where we can reach you, we can provide the exact verbiage that the Foundation requires and who to send it-to.

(As far as I can tell from this comment thread that is the desired license change.)

In the interest of completeness, I'll mention that the Eclipse Theia project also has a sub-license: GNU General Public License, version 2 with GNU Classpath Exception. The provided verbiage will contain the exact licenses we want to re-license the targeted content, to.

[richardfontana]

@marcdumais-work Sure, you can use [email protected].

[JonasHelming]

Update: All individuals agreed (updated in the wiki)

[JonasHelming]

I think all permissions are granted by now (https://github.com/theia-ide/generator-theia-extension/wiki/Re-licensing-theia-ide-generator-theia-extension)

[marcdumais-work]

Hi @richardfontana , @benoitf ,

Our re-licensing email discussion has stalled, when it was so close to being finalised. We'd like to go forward with the move, and the foundation is asking whether we can remove Red Hat's related commits to unblock the exercise, which we would rather not do (whether it contain IP or not, documentation is useful). Maybe we can quickly wrap this up to everyone's satisfaction?

[vince-fugnitto]

Re-licensing seems to now be completed, the latest status presented in the wiki (https://github.com/eclipse-theia/generator-theia-extension/wiki/Re-licensing-theia-ide-generator-theia-extension) is done. I believe it is fine to close the issue @marcdumais-work ?

[marcdumais-work]

The repo has moved to the eclipse-theia GH org (automatic redirect for the old URL):
https://github.com/eclipse-theia/generator-theia-extension

There may things the Foundation asks us to do following the move (the CQ I think is still under analysis), but we're done for this issue here.