Edge: Inherit dark theme from Eclipse #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I plan to merge this for M2. @HeikoKlare @amartya4256 any objections? |
BeckerWdf
approved these changes
Oct 14, 2024
HeikoKlare
approved these changes
Oct 14, 2024
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
Outdated
Show resolved
Hide resolved
HeikoKlare
force-pushed
the
edge-darktheme
branch
from
dc669c3
to
c7f4cc3
Compare
Set ICoreWebView2Profile#put_PreferredColorScheme() based on the Eclipse theme, if this is dark. The same way it is done in Display.setData(USE_DARKMODE_EXPLORER_THEME_KEY, ...) via OS.SetPreferredAppMode(PreferredAppMode_...);
lathapatil
pushed a commit
to swt-initiative31/prototype-gtk
that referenced
this pull request
Nov 14, 2024
In the scenario - System: Dark - Eclipse: Light we need to explicitly set - Edge: Light as well, as with the previous - Edge: Auto it would inherit 'Dark' from the system, which is not desired. Follow-up on 4d61d1d / eclipse-platform#1530.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set ICoreWebView2Profile#put_PreferredColorScheme() based on the Eclipse theme, if this is dark.
The same way it is done in
Display.setData(USE_DARKMODE_EXPLORER_THEME_KEY, ...)
via
OS.SetPreferredAppMode(PreferredAppMode_...);
Fixes #1529