Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge: Inherit dark theme from Eclipse #1529

Closed
sratz opened this issue Oct 10, 2024 · 0 comments · Fixed by #1530
Closed

Edge: Inherit dark theme from Eclipse #1529

sratz opened this issue Oct 10, 2024 · 0 comments · Fixed by #1530
Assignees
Labels
edge Edge Browser
Milestone

Comments

@sratz
Copy link
Member

sratz commented Oct 10, 2024

Currently the WebView2 instances use COREWEBVIEW2_PREFERRED_COLOR_AUTO, i.e. they inherit the dark/light setting from the operating system, not the Eclipse application.

E.g., when setting the preferred app theme in Windows to 'light', but Eclipse to 'dark', the Edge browser will use 'light'.

It should however inherit from Eclipse and also use 'dark'.

To do this, the API https://learn.microsoft.com/en-us/microsoft-edge/webview2/reference/win32/icorewebview2profile#put_preferredcolorscheme needs to be implemented.

@sratz sratz added the edge Edge Browser label Oct 10, 2024
@sratz sratz added this to the 4.34 M2 milestone Oct 10, 2024
@sratz sratz self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
edge Edge Browser
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant