Migrate javax.inject and javax.annotations to Jakarta

[HannesWell]

This is an umbrella issue to coordinate and collect the migration steps of the javax.inject and java.annotations bundles to Jakarta.

• Migrate to the javax.inject|annotations bundles provided by Jakarta but with unchanged package names

  1. Only use Import-Package with a closed version range to reference javax.inject|annotations in Plugin Manifests.

     • Simplifies the exchange of the providing bundle
     • Additionally prevents possible split-package problems with the javax.annotation package provided by the com.google.code.findbugs/jsr305 artifact. It is not used within the Eclipse platform but it guards down-stream consumers that could have it in their TP. E.g. Guava has a transitive dependency on it, so there is some chance it ends up in a TP if one is not careful.
     • PRs
       • Improve OSGi metadata about dependency to javax.inject/annotations eclipse-pde/eclipse.pde#591
       • Improve OSGi metadata about dependency to javax.inject/annotations eclipse-jdt/eclipse.jdt.core#1019
       • Improve OSGi metadata about dependency to javax.inject/annotations eclipse.platform#431
       • Improve OSGi metadata about dependency to javax.inject/annotations eclipse.platform.debug#133
       • Improve OSGi metadata about dependency to javax.inject/annotations eclipse.platform.ua#121
       • Improve OSGi metadata about dependency to javax.inject/annotations eclipse.platform.ui#738

  2. Refactor code to not relay on the bundle-symbolicName of the javax-annotations provider bundle so that it can be easaly exchanged

     • Remove javax bundles from org.eclipse.e4.rcp Feature eclipse.platform.ui#745
     • Migrate to javax.inject/annotation provided by Jakarta from Maven-Ctrl. eclipse.platform.common#145
     • Prepare javax to jakarta migration and simplify E4 wizards and templates eclipse-pde/eclipse.pde#593

  3. Replace javax-artifacts in the TP with the ones provided by Jakarta

     • Add javax.inject/annotation provided by Jakarta from Maven-Central and include all sources in Eclipse SDK repo #1057
     • Remove all javax bundles provided by Eclipse-Orbit #1059

• Support Annotations from jakarta.inject|annotations in all processors in the Eclipse platform

  • Add new jakarta.inject|annotations bundles to TP which version?
    • jakarta.inject:jakarta.inject-api:2.0.1
    • jakarta.annotation:jakarta.annotation-api:2.1.1
  • Support Jakarta Annotations in the E4 Injector (will create a dedicated issue):
    • Support jakarta.inject / jakarta.annotation in E4 as an alternative eclipse.platform#696
    • Make javax-annotations optional for E4 Injector eclipse.platform#792
    • Add switch to disable/enable javax-annotation processing for E4-Injector eclipse.platform#820
  • Are there more processors in the Eclipse-Platform?
    Looks like there are not more.

• Migrate all uses of the javax.inject|annotations packages to jakarta.inject|annotations

  • Support jakarta.inject / jakarta.annotation in E4 as an alternative eclipse.platform#696
  • Migrate from javax.inject/annotation to jakarta.inject/annotation eclipse.platform#789
  • Add o.e.e4.core.javax.tests as javax-using copy of o.e.e4.core.tests eclipse.platform#791
  • Migrate from javax.inject/annotation to jakarta.inject/annotation eclipse.platform.ui#1255
  • Migrate from javax.annotation to jakarta.annotation eclipse.platform.swt#852
  • Migrate Tests from javax.inject to jakarta.inject annotations eclipse-jdt/eclipse.jdt.core#1527
  • Migrate PDE from javax.inject/annotation to jakarta.inject/annotation eclipse-pde/eclipse.pde#833

I'll start to work on the steps and update this initial comment with the created PRs.

[HannesWell]

The javax.inject/annotation bundles are also contained in some products and one feature. I think we can simply remove them there.
In the PDE the javax.inject/annotation bundle are also referenced as Packages and as Plugins in the E4 templates.
At least the parts where they are referenced as Plugins should be rewritten to use packages immediately.
And later, when the transition to the jakarta annotations is possible the package imports in the templates have to be adjusted too.

[HannesWell]

Once the following PRs are submitted I consider the migration as completed:

• Add javax.inject/annotation providing bundles to eclipse.sdk repository #1509
• Add deprecation notice for javax support by the E4 injector #1510
• Add N&N about support for jakarta.inject/annotation in E4-injector www.eclipse.org-eclipse#79

Should we already open an issue in eclipse.platform about the eventual removal of support for javax-annotation in the injector?

[akurtakov]

Is there anything still to be done here?

[HannesWell]

Is there anything still to be done here?

With #1510 being merged, I now consider this as resolved.