Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate PDE from javax.inject/annotation to jakarta.inject/annotation #833

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

HannesWell
Copy link
Member

@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Test Results

     270 files  ±0       270 suites  ±0   1h 18m 8s ⏱️ + 10m 8s
  3 327 tests ±0    3 297 ✔️ ±0  30 💤 ±0  0 ±0 
10 278 runs  ±0  10 188 ✔️ ±0  90 💤 ±0  0 ±0 

Results for commit 0d5d490. ± Comparison against base commit 5cb1152.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell force-pushed the jakarta-annotations branch 5 times, most recently from 9265a3c to e673f9d Compare October 28, 2023 22:22
@HannesWell HannesWell marked this pull request as draft October 29, 2023 01:19
@HannesWell HannesWell marked this pull request as ready for review October 29, 2023 18:01
@HannesWell
Copy link
Member Author

This PR is ready and in generally works.
Only the Jenkins build fails with an OutOfMememoryException, unless one specifies the VM-arguments:

-Dorg.eclipse.jdt.disable_JRT_cache=true
-Dorg.eclipse.jdt.disable_CTSYM_cache=true

@laeubi
Copy link
Contributor

laeubi commented Oct 29, 2023

I created

once these are merged and there is a new ibuild they should be picked up and hopefully fix the issue wit OOM...

@HannesWell HannesWell merged commit d551a60 into eclipse-pde:master Oct 30, 2023
16 checks passed
@HannesWell HannesWell deleted the jakarta-annotations branch October 30, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants