Relocate the CodeGenerator::createOrFindClonedNode function from OMR #5790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test sanity all jdk11 |
|
I suggest you move the |
|
A couple of administrative nodes:
|
TR::Node *createOrFindClonedNode function in OMR::CodeGenerator has only relevance to the OpenJ9 project. Therefore, remove it from OMR and relocate it to the J9::CodeGenerator instead. In addition, fix the spelling mistake on _uncommonedNodes and relocate it from OMR to J9. Signed-off-by: Bohao(Aaron) Wang <[email protected]>
wbh123456
force-pushed
the
relocatecreateorfind
branch
from
5347aef to
deab173
Compare
wbh123456
changed the title
|
Jenkins test sanity all jdk11 |
0xdaryl
approved these changes
May 22, 2019
|
AIX builds are stalled due to infra issues. Everything else has passed. I'm satisfied with the testing. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TR::Node *createOrFindClonedNodefunction inOMR::CodeGeneratorhas only relevance to the OpenJ9 project. Therefore, remove it from OMR and relocate it to theJ9::CodeGeneratorinstead. In addition, fix the spelling mistake on_uncommonedNodesand relocate it from OMR to J9.Issue: eclipse-omr/omr#2068
Signed-off-by: Bohao(Aaron) Wang [email protected]