Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate createOrFindClonedNode to OpenJ9 #2068

Closed
0xdaryl opened this issue Nov 28, 2017 · 0 comments · Fixed by #3857
Closed

Relocate createOrFindClonedNode to OpenJ9 #2068

0xdaryl opened this issue Nov 28, 2017 · 0 comments · Fixed by #3857
Labels
backlog comp:compiler help wanted

Comments

@0xdaryl
Copy link
Contributor

0xdaryl commented Nov 28, 2017

The following OMR::CodeGenerator function only has relevance to the OpenJ9 project. It should be relocated to the J9::CodeGenerator class in that project instead.

TR::Node *createOrFindClonedNode(TR::Node *node, int32_t numChildren);

Also, the _uncommmonedNodes field and member initialization must be relocated.
@shivammittal99 shivammittal99 mentioned this issue Jan 28, 2018
Closed
@shivammittal99 shivammittal99 mentioned this issue Jan 28, 2018
Closed
shivammittal99 added a commit to shivammittal99/openj9 that referenced this issue Jun 28, 2018
@shivammittal99
Relocate createOrFindClonedNode, _uncommonedNodes from OMR
0cbf2cc 
OMR Issue: eclipse-omr/omr#2068
OMR PR: eclipse-omr/omr#2269

Signed-off-by: Shivam Mittal <[email protected]>
This was referenced May 16, 2019
Merged
Merged
@wbh123456 wbh123456 mentioned this issue May 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog comp:compiler help wanted
Projects
None yet
Milestone
No milestone
1 participant
@0xdaryl