Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK12 add new method java.lang.String.transform() #4745

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

JasonFengJ9
Copy link
Member

JDK12 add new method java.lang.String.transform()

Adding java.lang.String.transform() for JDK12.

Manually verified it matches RI results in a simple testcase as following:

    String strOne = "StringOne";
    System.out.println((Object)strOne.transform(string -> string.length()));

Expecting the test coverage is provided by JTReg tests
https://github.com/ibmruntimes/openj9-openjdk-jdk12/blob/e969f57ff8031485b00ccf2ed10f87a627c7bd68/test/jdk/java/lang/String/Transform.java#L24-L28

Related to: #3850

Reviewer: @pshipton
FYI: @DanHeidinga

Signed-off-by: Jason Feng [email protected]

Adding java.lang.String.transform() for JDK12.

Signed-off-by: Jason Feng <[email protected]>
@pshipton
Copy link
Member

pshipton commented Feb 14, 2019

Please add your test to the test suite.

@pshipton
Copy link
Member

Given the implementation is so simple and there is coverage elsewhere, I'll merge without a test.

@pshipton pshipton merged commit 542211d into eclipse-openj9:master Feb 14, 2019
@JasonFengJ9 JasonFengJ9 deleted the jdk12transform branch February 19, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants