Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New methods in String for jdk12 #3850

Closed
pshipton opened this issue Nov 27, 2018 · 11 comments
Closed

New methods in String for jdk12 #3850

pshipton opened this issue Nov 27, 2018 · 11 comments

Comments

@pshipton
Copy link
Member

pshipton commented Nov 27, 2018

indent(int)
transform​(Function<? super String,? extends R> f)
http://cr.openjdk.java.net/~iris/se/12/build/latest/api/java.base/java/lang/String.html

@JasonFengJ9
Copy link
Member

@theresa-m does your Java 12 PR cover the methods specified here?

@JasonFengJ9
Copy link
Member

There are couple of new additions:

public Optional<String> describeConstable()
public String resolveConstantDesc​(MethodHandles.Lookup lookup)

@theresa-m
Copy link
Contributor

I have not covered the align/indent/transform methods. describeConstable and resolveConstantDesc are part of jep334. the pr for them is #4105

@JasonFengJ9
Copy link
Member

It appears align() & align(int) have been removed.

@theresa-m
Copy link
Contributor

theresa-m commented Feb 4, 2019

@sharon-wang can you start look at indent(int)?

@pshipton
Copy link
Member Author

@JasonFengJ9 @theresa-m is somebody looking at transform?

@fjeremic
Copy link
Contributor

fjeremic commented Feb 13, 2019

@JasonFengJ9 @theresa-m is somebody looking at transform?

In addition I'd like to add to please take a look at the corresponding StringLatin1 and StringUTF16 classes to see if OpenJDK has already added helpers for these APIs which we can reuse. IIRC that was the case for some of the previous Java 12 methods.

@sharon-wang FYI as well.

@JasonFengJ9
Copy link
Member

is somebody looking at transform?

Not that I am aware of.

@pshipton
Copy link
Member Author

@DanHeidinga we need an implementation for String.transform​(Function<? super String,? extends R> f)

@theresa-m @sharon-wang any outlook for indent(int)? The feature complete date is Feb 25.
There is no StringLatin1, StringUTF16 helper.

@JasonFengJ9
Copy link
Member

Will take String.transform​(Function<? super String,? extends R> f).

@theresa-m
Copy link
Contributor

We're on it. @sharon-wang is working on some tests for the method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants