-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS: Use Clang for JDK8 JIT builds #3629
Conversation
Necessary for removing the JIT's dependency on libstdc++.6.0.9.dylib that results in failing to load libj9jit on newer macOS versions not having the right version of the library. Signed-off-by: Nazim Uddin Bhuiyan <[email protected]>
@nbhuiyan can this be delivered before the extensions change? Is the extensions change safe to deliver before this? Trying to understand which way the dependency goes so we can get these delivered without breaking the builds. |
@DanHeidinga , The extensions change would need to go first if we want to prevent breaking the OSX JDK8 builds. Without ibmruntimes/openj9-openjdk-jdk8#206 , we have to build the OpenJ9 portion using gcc-4.9 on macOS. This patch would add clang-specific compiler flags that causes gcc to error out. If there are currently no automated CI and builds set up for OSX jdk8 (my assumption), then it should not matter which PR gets delivered first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Jenkins test sanity osx jdk11 |
Running a jdk11 pr build to validate the file is still well formatted as we don't have jdk8 mac builds yet |
ibmruntimes/openj9-openjdk-jdk8#206 has been merged |
@DanHeidinga sanity test seems to have hanged after successfully building. Is that expected? |
|
Jenkins test sanity osx jdk11 |
No, that's not expected. Rekicked the build and will check it again tonight. |
CI job failed again. This time
fyi - @jdekonin |
merged as failures are machine configuration, not related to this pr |
Necessary for removing the JIT's dependency on
libstdc++.6.0.9.dylib that results in failing to load libj9jit on
newer macOS versions not having the right version of the library.
Signed-off-by: Nazim Uddin Bhuiyan [email protected]
Fixes: #3496
Depends on: ibmruntimes/openj9-openjdk-jdk8#206
Issue: #36