Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to OSX JDK8/JDK11 Setup #735

Closed
babsingh opened this issue Nov 13, 2018 · 2 comments
Closed

Changes to OSX JDK8/JDK11 Setup #735

babsingh opened this issue Nov 13, 2018 · 2 comments
Labels
duplicate Issues that are a duplicate of an issue in this (or another) repository

Comments

@babsingh
Copy link

babsingh commented Nov 13, 2018

  • For OSX JDK8, gcc49 is no longer needed. So, gcc49 should be uninstalled from machines: brew uninstall gcc49.
  • Changes to mac.sh:
    • Set MACOSX_DEPLOYMENT_TARGET to 10.9.0 for both JDK8 and JDK11 [mac.sh L21 and L62]. In the extensions repos,MACOSX_VERSION_MIN is used to set env var MACOSX_DEPLOYMENT_TARGET and compiler options. MACOSX_VERSION_MIN is set to 10.9.0 for both JDK8 and JDK11.
    • Remove --with-extra-cxxflags=-mmacosx-version-min=10.8 from L41. This will conflict with MACOSX_VERSION_MIN being set to 10.9.0 for JDK11.
    • Update configure options for OSX JDK8 mac.sh::L64:
from:
 export CONFIGURE_ARGS_FOR_ANY_PLATFORM="${CONFIGURE_ARGS_FOR_ANY_PLATFORM} --with-xcode-path=/Applications/Xcode.app --with-openj9-cc=/usr/local/bin/gcc-4.9 --with-openj9-cxx=/usr/local/bin/g++-4.9 --with-openj9-developer-dir=/Applications/Xcode7/Xcode.app/Contents/Developer"

to:
 export CONFIGURE_ARGS_FOR_ANY_PLATFORM="${CONFIGURE_ARGS_FOR_ANY_PLATFORM} --with-xcode-path=/Applications/Xcode.app --with-openj9-cc=/Applications/Xcode7/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang --with-openj9-cxx=/Applications/Xcode7/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ --with-openj9-developer-dir=/Applications/Xcode7/Xcode.app/Contents/Developer"

Note: The above changes should be applied after eclipse-openj9/openj9#3629 is merged.

Reference: eclipse-openj9/openj9#3323 (comment)

@babsingh
Copy link
Author

fyi - @sxa555

@babsingh
Copy link
Author

babsingh commented Nov 13, 2018

I was supposed to create the issue in AdoptOpenJDK/openjdk-infrastructure. Thus, closing this issue and creating a new one in AdoptOpenJDK/openjdk-infrastructure. Link to the new issue: adoptium/infrastructure#561.

@karianna karianna added the duplicate Issues that are a duplicate of an issue in this (or another) repository label Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues that are a duplicate of an issue in this (or another) repository
Projects
None yet
Development

No branches or pull requests

2 participants