Remove string to boolean expression conversion for node's labels #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the use of any boolean expression (can contain other logical operators not only AND). The variables file requires the labels to be provided as boolean expressions instead of strings (space separated labels) for multiple labels. It also checks first if the NODE is passed as argument. [ci skip] Signed-off-by: Violeta Sebe <[email protected]>
|
@jdekonin please review |
|
@pshipton please review |
AdamBrousseau
requested changes
Apr 26, 2018
There was a problem hiding this comment.
Won't this require an update to all the labels in the variable file?
Perhaps we should combine the change with the change needed to update to the Adopt label schema (#1562)
AdamBrousseau
approved these changes
Apr 26, 2018
|
@pshipton ready for review, thank you! |
pshipton
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the use of any boolean expression (can contain other logical
operators not only AND). The variables file requires the labels to be
provided as boolean expressions instead of strings (space separated
labels) for multiple labels.
It also checks first if the NODE is passed as argument.
[ci skip]
Signed-off-by: Violeta Sebe [email protected]