Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jenkins node labels to match AdoptOpenJDK label schema #1562

Closed
3 tasks done
AdamBrousseau opened this issue Mar 27, 2018 · 9 comments
Closed
3 tasks done

Update Jenkins node labels to match AdoptOpenJDK label schema #1562

AdamBrousseau opened this issue Mar 27, 2018 · 9 comments

Comments

@AdamBrousseau
Copy link
Contributor

AdamBrousseau commented Mar 27, 2018

Ref adoptium/infrastructure#93

Since we will be reusing Adopt test JenkinsFiles (#1450), it would be a good idea to have the same node labelling schema. We should only add the labels we need.

We could also use NodeHelper API and NodeLabel job

Labels to add

zLinux

  • hw.arch.s390x
  • sw.os.linux
  • sw.os.ubuntu
  • sw.os.ubuntu.16

pLinux

  • hw.arch.ppc64le
  • sw.os.linux
  • sw.os.ubuntu
  • sw.os.ubuntu.16

aix

  • hw.arch.ppc64
  • sw.os.aix
  • sw.os.aix.7_2
@AdamBrousseau
Copy link
Contributor Author

@llxia can you confirm which os label you want/prefer for test.
i.e. sw.os.linux or sw.os.ubuntu or sw.os.ubuntu.16

@llxia
Copy link
Contributor

llxia commented Mar 28, 2018

Talked with Adam, we should use the same labeling across sites and we can use Shubham's tool to label machine automatically.

@llxia
Copy link
Contributor

llxia commented Apr 26, 2018

As we use Jenkins files from AdoptOpenJDK for test and both sites have different labeling schema, we pass in LABEL as parameter for now.
For example:
https://ci.eclipse.org/openj9/view/Test/job/Test-Sanity-Functional-JDK8-linux_390-64_cmprssptrs/

@AdamBrousseau
Copy link
Contributor Author

@llxia I have updated the machines with the new labels

@llxia
Copy link
Contributor

llxia commented Jun 25, 2018

Please note that test jobs are using the passed in LABEL parameter. If the label is changed, please update the default value in the test jobs.

For example:
https://ci.eclipse.org/openj9/view/Test/job/Test-sanity.functional-JDK10-aix_ppc-64_cmprssptrs/configure

Once the labels are in sync between OpenJ9 and AdoptOpenJDK, we should not need LABEL parameter any more.

AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this issue Jul 17, 2018
- Change aix,ppcle,390
- Remove ubuntu version
- Update to hierarchical labels based on standardized
  schema defined in adoptium/infrastructure#93
- Also remove nestmates spec which was added by default (eclipse-openj9#2270)

Issue eclipse-openj9#1562
[skip ci]

Signed-off-by: Adam Brousseau <[email protected]>
@AdamBrousseau
Copy link
Contributor Author

Waiting on adoptium/aqa-tests#481 before I remove the old labels

@smlambert
Copy link
Contributor

adoptium/aqa-tests#481 has been merged

@AdamBrousseau
Copy link
Contributor Author

This is now complete. Thanks @smlambert and @llxia for helping drive this at Adopt

@llxia
Copy link
Contributor

llxia commented Jul 18, 2018

Updated all test jobs to set default value for LABEL to be empty ( LABEL option is kept just in case we need it for debugging). All test jobs will use the LABEL value from the AdoptOpenJDK test script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants