Fix javadoc errors and add explicit constructors #17077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
commented
Mar 30, 2023
Comment on lines
+37
to
+39
| private ContextFactory() { | ||
| /* no instances needed */ | ||
| } |
There was a problem hiding this comment.
This class was internal until #17064; the class only has static features so instances are not required.
|
Testing underway in ibmruntimes/openj9-openjdk-jdk#572; see https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJDKnext/140. |
JasonFengJ9
reviewed
Mar 30, 2023
| * @return the context | ||
| */ | ||
| public static IDTFJContext getContext(final int major, final int minor,final Image image, final ImageAddressSpace space, final ImageProcess proc, final JavaRuntime rt) { | ||
| DTFJContext ctx = new DTFJContext(major, minor, image, space, proc, rt); | ||
| public static IDTFJContext getContext(final int major, final int minor,final Image image, final ImageAddressSpace space, final ImageProcess process, final JavaRuntime runtime) { |
There was a problem hiding this comment.
Thanks. I'll fix that.
There was a problem hiding this comment.
Fixed in 05fa502.
|
Pls fix the commit title to indicate constructors are also updated. |
* add missing @param Signed-off-by: Keith W. Campbell <[email protected]>
keithc-ca
changed the title
|
Now the commit title and the headline here mention the constructors. |
pshipton
approved these changes
Mar 31, 2023
|
Pls cherry pick for 0.38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix javadoc errors seen in https://openj9-jenkins.osuosl.org/job/Build_JDKnext_aarch64_linux_Personal/47.
Also