-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix javadoc errors and add explicit constructors #17077
Conversation
private ContextFactory() { | ||
/* no instances needed */ | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class was internal until #17064; the class only has static features so instances are not required.
Testing underway in ibmruntimes/openj9-openjdk-jdk#572; see https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJDKnext/140. |
* @return the context | ||
*/ | ||
public static IDTFJContext getContext(final int major, final int minor,final Image image, final ImageAddressSpace space, final ImageProcess proc, final JavaRuntime rt) { | ||
DTFJContext ctx = new DTFJContext(major, minor, image, space, proc, rt); | ||
public static IDTFJContext getContext(final int major, final int minor,final Image image, final ImageAddressSpace space, final ImageProcess process, final JavaRuntime runtime) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@param image
is missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'll fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 05fa502.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pls fix the commit title to indicate constructors are also updated. |
* add missing @param Signed-off-by: Keith W. Campbell <[email protected]>
Now the commit title and the headline here mention the constructors. |
Pls cherry pick for 0.38 |
Fix javadoc errors seen in https://openj9-jenkins.osuosl.org/job/Build_JDKnext_aarch64_linux_Personal/47.
Also