-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export dtfj packages required for plugins #17064
Conversation
@keithc-ca I'm checking with Manqing if there are additional packages we should export, but what I've exported so far is enough to run the summaryInfo test plugin. Checking if you have any initial feedback. |
@@ -29,7 +29,7 @@ | |||
requires openj9.dtfj; | |||
requires java.logging; | |||
|
|||
exports com.ibm.jvm.dtfjview.commands to openj9.dtfj; | |||
exports com.ibm.jvm.dtfjview.commands; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable, but I don't see any use in openj9.dtfj (as should be the case, otherwise there's a dependency cycle involving the two modules), so I don't know why it was added in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On further reflection, I'm reluctant to make this change. I think plugin commands should extend com.ibm.java.diagnostics.utils.commands.BaseCommand
instead of com.ibm.jvm.dtfjview.commands.BaseJdmpviewCommand
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. I've made the update and confirmed a plugin that subclasses BaseCommand instead of BaseJdmpviewCommand still works.
Manqing didn't have any additional packages being used for a |
Issue eclipse-openj9#16783 Signed-off-by: Peter Shipton <[email protected]>
Issue #16783
A test plugin installed via
-Dcom.ibm.java.diagnostics.plugins
uses the following classes: