Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK18 adds --finalization=[enabled|disabled] #14116

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

JasonFengJ9
Copy link
Member

Added J9_EXTENDED_RUNTIME_DISABLE_FINALIZATION;
Implemented JVM_IsFinalizationEnabled;
Accepted command line option --finalization=[enabled|disabled].

related to #14049
depends on #14113

Signed-off-by: Jason Feng [email protected]

@pshipton
Copy link
Member

pshipton commented Dec 8, 2021

jenkins compile win jdknext

@pshipton
Copy link
Member

pshipton commented Dec 8, 2021

#14113 (comment) requires an update so this will need to be updated as well before merge.

runtime/vm/jvminit.c Outdated Show resolved Hide resolved
@pshipton
Copy link
Member

pshipton commented Dec 8, 2021

runtime/vm/jvminit.c Outdated Show resolved Hide resolved
@pshipton
Copy link
Member

pshipton commented Dec 8, 2021

Pls fix the conflict now.

@pshipton
Copy link
Member

pshipton commented Dec 8, 2021

Keith's commit is merged so it can be removed from this PR.

Added J9_EXTENDED_RUNTIME_DISABLE_FINALIZATION;
Implemented JVM_IsFinalizationEnabled;
Accepted command line option --finalization=[enabled|disabled].

Signed-off-by: Jason Feng <[email protected]>
@JasonFengJ9
Copy link
Member Author

Pls fix the conflict now.

Resolved the conflict.

@pshipton pshipton merged commit 5b77388 into eclipse-openj9:master Dec 9, 2021
@JasonFengJ9 JasonFengJ9 deleted the disablefinalizer branch April 4, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants