-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK18 adds --finalization=[enabled|disabled] #14116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenkins compile win jdknext |
#14113 (comment) requires an update so this will need to be updated as well before merge. |
keithc-ca
reviewed
Dec 8, 2021
Running PR build https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/1308/ |
JasonFengJ9
force-pushed
the
disablefinalizer
branch
from
December 8, 2021 20:05
e3cb47c
to
058582e
Compare
keithc-ca
reviewed
Dec 8, 2021
JasonFengJ9
force-pushed
the
disablefinalizer
branch
from
December 8, 2021 20:09
058582e
to
0d3cd0f
Compare
Pls fix the conflict now. |
Keith's commit is merged so it can be removed from this PR. |
Added J9_EXTENDED_RUNTIME_DISABLE_FINALIZATION; Implemented JVM_IsFinalizationEnabled; Accepted command line option --finalization=[enabled|disabled]. Signed-off-by: Jason Feng <[email protected]>
JasonFengJ9
force-pushed
the
disablefinalizer
branch
from
December 8, 2021 21:33
0d3cd0f
to
f55f232
Compare
Resolved the conflict. |
pshipton
approved these changes
Dec 8, 2021
keithc-ca
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
J9_EXTENDED_RUNTIME_DISABLE_FINALIZATION
;Implemented
JVM_IsFinalizationEnabled
;Accepted command line option
--finalization=[enabled|disabled]
.related to #14049
depends on #14113
Signed-off-by: Jason Feng [email protected]